mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
To: Willy Tarreau <willy@w.ods.org>,
	Athol Mullen <athol_SPIT_SPAM@idl.net.au>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] IDE 80-core cable detect - chipset-specific code to over-ride eighty_ninty_three()
Date: Tue, 10 Feb 2004 01:10:26 +0100	[thread overview]
Message-ID: <200402100110.26513.bzolnier@elka.pw.edu.pl> (raw)
In-Reply-To: <20040208073151.GC29363@alpha.home.local>

On Sunday 08 of February 2004 08:31, Willy Tarreau wrote:
> On Sun, Feb 08, 2004 at 11:45:18AM +1100, Athol Mullen wrote:
> > Before I modified eighty_ninty_three(), it returning 0 caused the
> > _indicated_ mode to drop to UDMA33.  Check in /proc/ide/piix to see what
> > mode the driver tells you.  IIRC (could be wrong), dmesg and hdparm both
> > believe it to be in UDMA33 while the init code and /proc/ide/piix both
> > showed it as UDMA5.

So host recognizes 80-wires cable correctly, but drive doesn't.
eighty_ninty_three() is for checking _drive_ side.

> I captured dmesg and /proc/ide/piix, but forgot to post them. They're at
> work now. But I did the change, by commenting out the call to
> eighty_ninety_three() in piix.c, and my disks came back to 54 MB/s each,
> and 64 MB/s cumulated. dmesg showed UDMA33 before and now displays UDMA100
> again. But I obviously cannot let it like that because if I install this
> kernel in a 40-pin machine, I will get some surprizes !

This is eighty_ninty_three() in 2.6.x (except #if 0 (...) #endif code):

u8 eighty_ninty_three (ide_drive_t *drive)
{
	return ((u8) ((HWIF(drive)->udma_four) &&
#ifndef CONFIG_IDEDMA_IVB
			(drive->id->hw_config & 0x4000) &&
#endif /* CONFIG_IDEDMA_IVB */
			(drive->id->hw_config & 0x6000)) ? 1 : 0);
#endif
}

Maybe you have accidentally enabled CONFIG_IDEDMA_IVB?
If not please send me copy of /proc/ide/hdX/identify for your drives.

--bart


  reply	other threads:[~2004-02-10  0:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1mtPj-7oQ-3@gated-at.bofh.it>
     [not found] ` <1mwNn-1xb-27@gated-at.bofh.it>
2004-02-08  0:45   ` Athol Mullen
2004-02-08  7:31     ` Willy Tarreau
2004-02-10  0:10       ` Bartlomiej Zolnierkiewicz [this message]
2004-02-10  0:37         ` Bartlomiej Zolnierkiewicz
     [not found] <1n9OA-6lu-17@gated-at.bofh.it>
     [not found] ` <1n9OA-6lu-23@gated-at.bofh.it>
     [not found]   ` <1n9OA-6lu-15@gated-at.bofh.it>
     [not found]     ` <1nu6y-XO-3@gated-at.bofh.it>
2004-02-10  7:16       ` Athol Mullen
2004-02-10 14:41         ` Bartlomiej Zolnierkiewicz
     [not found] <1mLsS-6Oq-7@gated-at.bofh.it>
     [not found] ` <1mLsS-6Oq-9@gated-at.bofh.it>
     [not found]   ` <1mLsS-6Oq-5@gated-at.bofh.it>
     [not found]     ` <1mRHV-4Xn-7@gated-at.bofh.it>
2004-02-09  2:50       ` Athol Mullen
2004-02-09 20:04         ` Willy Tarreau
2004-02-10  0:24         ` Bartlomiej Zolnierkiewicz
2004-02-07  6:00 Athol Mullen
2004-02-07  9:15 ` Willy Tarreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200402100110.26513.bzolnier@elka.pw.edu.pl \
    --to=b.zolnierkiewicz@elka.pw.edu.pl \
    --cc=athol_SPIT_SPAM@idl.net.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=willy@w.ods.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®