From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: kas@informatics.muni.cz
Cc: linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org
Subject: Re: [Patch] Netlink BUG() on AMD64
Date: Thu, 12 Feb 2004 03:45:37 +0900 (JST) [thread overview]
Message-ID: <20040212.034537.11291491.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <20040211181113.GA2849@fi.muni.cz>
In article <20040211181113.GA2849@fi.muni.cz> (at Wed, 11 Feb 2004 19:11:14 +0100), Jan Kasprzak <kas@informatics.muni.cz> says:
> I suggest the following patch, but all occurences of
> nlmsg_failure: and rtattr_failure: labels should be checked for a similar
> problem.
>
> --- linux-2.6.2/net/ipv4/fib_rules.c.orig 2004-02-11 18:55:58.000000000 +0100
> +++ linux-2.6.2/net/ipv4/fib_rules.c 2004-02-11 19:03:08.319215408 +0100
> @@ -438,7 +438,7 @@
>
> nlmsg_failure:
> rtattr_failure:
> - skb_put(skb, b - skb->tail);
> + skb_trim(skb, b - skb->data);
> return -1;
> }
>
> Please apply or let me know what the proper fix should be.
looks good to me.
Other places including net/ipv6/{addrconf.c,route.c} seems okay.
--yoshfuji
next prev parent reply other threads:[~2004-02-11 18:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-05 17:36 Jan Kasprzak
2004-02-11 18:11 ` [Patch] " Jan Kasprzak
2004-02-11 18:45 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
2004-02-11 18:58 ` YOSHIFUJI Hideaki / 吉藤英明
2004-02-12 3:49 ` David S. Miller
2004-02-12 4:10 ` Jan Kasprzak
2004-02-12 4:23 ` David S. Miller
2004-02-12 14:05 ` kuznet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040212.034537.11291491.yoshfuji@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=kas@informatics.muni.cz \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®