From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266162AbUBKS5b (ORCPT ); Wed, 11 Feb 2004 13:57:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266163AbUBKS5b (ORCPT ); Wed, 11 Feb 2004 13:57:31 -0500 Received: from yue.hongo.wide.ad.jp ([203.178.135.30]:16656 "EHLO yue.hongo.wide.ad.jp") by vger.kernel.org with ESMTP id S266162AbUBKS53 (ORCPT ); Wed, 11 Feb 2004 13:57:29 -0500 Date: Thu, 12 Feb 2004 03:58:25 +0900 (JST) Message-Id: <20040212.035825.101259632.yoshfuji@linux-ipv6.org> To: kas@informatics.muni.cz, davem@redhat.com Cc: linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org Subject: Re: [Patch] Netlink BUG() on AMD64 From: YOSHIFUJI Hideaki / =?iso-2022-jp?B?GyRCNUhGIzFRTEAbKEI=?= In-Reply-To: <20040212.034537.11291491.yoshfuji@linux-ipv6.org> References: <20040205183604.N26559@fi.muni.cz> <20040211181113.GA2849@fi.muni.cz> <20040212.034537.11291491.yoshfuji@linux-ipv6.org> Organization: USAGI Project X-URL: http://www.yoshifuji.org/%7Ehideaki/ X-Fingerprint: 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA X-PGP-Key-URL: http://www.yoshifuji.org/%7Ehideaki/hideaki@yoshifuji.org.asc X-Face: "5$Al-.M>NJ%a'@hhZdQm:."qn~PA^gq4o*>iCFToq*bAi#4FRtx}enhuQKz7fNqQz\BYU] $~O_5m-9'}MIs`XGwIEscw;e5b>n"B_?j/AkL~i/MEaZBLP X-Mailer: Mew version 2.2 on Emacs 20.7 / Mule 4.1 (AOI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org In article <20040212.034537.11291491.yoshfuji@linux-ipv6.org> (at Thu, 12 Feb 2004 03:45:37 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 says: > In article <20040211181113.GA2849@fi.muni.cz> (at Wed, 11 Feb 2004 19:11:14 +0100), Jan Kasprzak says: > > > I suggest the following patch, but all occurences of > > nlmsg_failure: and rtattr_failure: labels should be checked for a similar > > problem. > > > > --- linux-2.6.2/net/ipv4/fib_rules.c.orig 2004-02-11 18:55:58.000000000 +0100 > > +++ linux-2.6.2/net/ipv4/fib_rules.c 2004-02-11 19:03:08.319215408 +0100 > > @@ -438,7 +438,7 @@ > > > > nlmsg_failure: > > rtattr_failure: > > - skb_put(skb, b - skb->tail); > > + skb_trim(skb, b - skb->data); > > return -1; > > } > > > > Please apply or let me know what the proper fix should be. > > looks good to me. > Other places including net/ipv6/{addrconf.c,route.c} seems okay. Oops, I'd looked into ipv4 and ipv6 only. I've grep'ed and found one in net/decnet. ===== net/decnet/dn_rules.c 1.6 vs edited ===== --- 1.6/net/decnet/dn_rules.c Fri May 9 01:46:11 2003 +++ edited/net/decnet/dn_rules.c Thu Feb 12 03:52:42 2004 @@ -381,7 +381,7 @@ nlmsg_failure: rtattr_failure: - skb_put(skb, b - skb->tail); + skb_trim(skb, b - skb->data); return -1; } -- Hideaki YOSHIFUJI @ USAGI Project GPG FP: 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA