From: Jamie Lokier <jamie@shareable.org>
To: "David S. Miller" <davem@redhat.com>
Cc: dsaxena@plexity.net, mporter@kernel.crashing.org,
lists@mdiehl.de, linux-kernel@vger.kernel.org
Subject: Re: [Patch] dma_sync_to_device
Date: Fri, 13 Feb 2004 01:49:53 +0000 [thread overview]
Message-ID: <20040213014953.GB25499@mail.shareable.org> (raw)
In-Reply-To: <20040211110853.492f479b.davem@redhat.com>
David S. Miller wrote:
> It is different. pci_dma_sync_single(..., DMA_TO_DEVICE), on MIPS for example,
> would do absolutely nothing. At mapping time, the local cpu cache was flushed,
> and assuming the MIPS pci controllers don't have caches of their own there is
> nothing to flush there either.
>
> Whereas pci_dma_sync_device_single() would flush the dirty lines from the cpu
> caches. In fact, it will perform the same CPU cache flushes as pci_map_single()
> did, using MIPS as the example again.
The names are a bit confusing.
How about changing them to:
pci_dma_sync_single => pci_dma_sync_for_cpu
pci_dma_sync_device_single => pci_dma_sync_for_device
-- Jamie
next prev parent reply other threads:[~2004-02-13 1:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-10 17:31 Martin Diehl
2004-02-10 18:42 ` David S. Miller
2004-02-10 18:59 ` Martin Diehl
2004-02-11 6:17 ` Deepak Saxena
2004-02-11 6:51 ` Martin Diehl
2004-02-11 16:39 ` Deepak Saxena
2004-02-11 17:51 ` David S. Miller
2004-02-11 18:18 ` Matt Porter
2004-02-11 18:30 ` David S. Miller
2004-02-11 18:57 ` Deepak Saxena
2004-02-11 19:08 ` David S. Miller
2004-02-12 3:46 ` Deepak Saxena
2004-02-12 3:58 ` David S. Miller
2004-02-13 1:49 ` Jamie Lokier [this message]
2004-02-14 7:24 ` David S. Miller
2004-02-11 19:23 ` Matt Porter
2004-02-11 19:30 ` David S. Miller
2004-02-11 18:43 ` linux-2.6.2 Kernel Problem Elikster
2004-02-14 11:51 ` Adrian Bunk
2004-02-13 14:27 [Patch] dma_sync_to_device James Bottomley
2004-02-14 8:51 ` Martin Diehl
2004-02-14 22:34 ` James Bottomley
2004-02-14 23:18 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040213014953.GB25499@mail.shareable.org \
--to=jamie@shareable.org \
--cc=davem@redhat.com \
--cc=dsaxena@plexity.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@mdiehl.de \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®