From: viro@parcelfarce.linux.theplanet.co.uk
To: jt@hpl.hp.com
Cc: "David S. Miller" <davem@redhat.com>,
Jeff Garzik <jgarzik@pobox.com>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Stephen Hemminger <shemminger@osdl.org>
Subject: Re: [PATCH 2.6 IrDA] new driver : stir4200
Date: Sat, 14 Feb 2004 04:21:34 +0000 [thread overview]
Message-ID: <20040214042134.GG8858@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040214015059.GA25979@bougret.hpl.hp.com>
On Fri, Feb 13, 2004 at 05:50:59PM -0800, Jean Tourrilhes wrote:
> +static void stir_disconnect(struct usb_interface *intf)
> +{
> + struct stir_cb *stir = usb_get_intfdata(intf);
> + struct net_device *net;
> +
> + usb_set_intfdata(intf, NULL);
> + if (!stir)
> + return;
> +
> + /* Stop transmitter */
> + net = stir->netdev;
> + netif_device_detach(net);
> +
> + /* Remove netdevice */
> + unregister_netdev(net);
> +
> + /* No longer attached to USB bus */
> + stir->usbdev = NULL;
> +
> + free_netdev(net);
> +}
1) Do we need netif_device_detach() there?
2) Shouldn't we leave usb_set_intfdata() until after unregister_netdev()?
next prev parent reply other threads:[~2004-02-14 4:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-14 1:50 Jean Tourrilhes
2004-02-14 4:21 ` viro [this message]
2004-02-14 7:06 ` David S. Miller
2004-02-14 12:56 ` Francois Romieu
2004-02-14 20:40 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040214042134.GG8858@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=davem@redhat.com \
--cc=jgarzik@pobox.com \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®