From: Adrian Bunk <bunk@fs.tum.de>
To: Peter Cordes <peter@cordes.ca>,
Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: typo: HOSTCCFLAGS instead of HOSTCFLAGS in lib/Makefile
Date: Sat, 14 Feb 2004 13:10:13 +0100 [thread overview]
Message-ID: <20040214121013.GI1308@fs.tum.de> (raw)
In-Reply-To: <20040210233102.GH5388@llama.nslug.ns.ca>
On Tue, Feb 10, 2004 at 07:31:02PM -0400, Peter Cordes wrote:
>
> In lib/Makefile in Linux 2.4.24, near the end there is:
> gen_crc32table: gen_crc32table.c
> $(HOSTCC) $(HOSTCCFLAGS) -o $@ $<
> ^^
> It should be HOSTCFLAGS, not HOSTCCFLAGS.
>
> There aren't any other instances of HOSTCCFLAGS in 2.4.24, or any in 2.6.1.
Nice spotting!
@Marcelo:
Please apply the patch below.
> please CC on replies, since I'm not subscribed.
cu
Adrian
--- linux-2.4.25-rc2-full/lib/Makefile.old 2004-02-14 13:02:36.000000000 +0100
+++ linux-2.4.25-rc2-full/lib/Makefile 2004-02-14 13:02:47.000000000 +0100
@@ -42,7 +42,7 @@
crc32.o: crc32table.h
gen_crc32table: gen_crc32table.c
- $(HOSTCC) $(HOSTCCFLAGS) -o $@ $<
+ $(HOSTCC) $(HOSTCFLAGS) -o $@ $<
crc32table.h: gen_crc32table
./$< > $@
prev parent reply other threads:[~2004-02-14 12:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-10 23:31 Peter Cordes
2004-02-14 12:10 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040214121013.GI1308@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=peter@cordes.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®