From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264163AbUBOHDl (ORCPT ); Sun, 15 Feb 2004 02:03:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264238AbUBOHDl (ORCPT ); Sun, 15 Feb 2004 02:03:41 -0500 Received: from dp.samba.org ([66.70.73.150]:27541 "EHLO lists.samba.org") by vger.kernel.org with ESMTP id S264163AbUBOHDk (ORCPT ); Sun, 15 Feb 2004 02:03:40 -0500 From: Rusty Russell To: torvalds@osdl.org, akpm@osdl.org Cc: Keith M Wesolowski , linux-kernel@vger.kernel.org Subject: [PATCH]: Sparc no longer Fucked Up Date: Sun, 15 Feb 2004 13:44:43 +1100 Message-Id: <20040215070352.1B07F2C0F8@lists.samba.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org From: Keith M Wesolowski As of 2.6.3, restore_flags will no longer modify cwp on sparc. Therefore you can apply this patch to the locking guide. [ Indeed. I'll also remove the atomic comments from Hacking Guide as part of my revision there when I get back to it. --RR ] diff -Nru a/Documentation/DocBook/kernel-locking.tmpl b/Documentation/DocBook/kernel-locking.tmpl --- a/Documentation/DocBook/kernel-locking.tmpl Sun Feb 8 15:07:26 2004 +++ b/Documentation/DocBook/kernel-locking.tmpl Sun Feb 8 15:07:26 2004 @@ -1444,27 +1444,6 @@ - - The Fucked Up Sparc - - - Alan Cox says the irq disable/enable is in the register - window on a sparc. Andi Kleen says when you do - restore_flags in a different function you mess up all the - register windows. - - - - So never pass the flags word set by - spin_lock_irqsave() and brethren to another - function (unless it's declared inline). Usually no-one - does this, but now you've been warned. Dave Miller can never do - anything in a straightforward manner (I can say that, because I have - pictures of him and a certain PowerPC maintainer in a compromising - position). - - - -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell.