From: BlaisorBlade <blaisorblade_spam@yahoo.it>
To: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: [PATCH] Trivial -critical : BUG()gy behaviour on OOM
Date: Sun, 15 Feb 2004 16:47:39 +0100 [thread overview]
Message-ID: <200402151647.39907.blaisorblade_spam@yahoo.it> (raw)
[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]
In short: in vanilla 2.6.3-rc2 (and also 2.6.2-mm1) do_swap_page() can return
-ENOMEM while value return values are VM_FAULT_*; invalid return values can
result in BUG() being called, so this patch (or a better fix) should go in
soon. This patch corrects this by returning VM_FAULT_OOM in that case.
CC me on replies, please, as I'm not subscribed. Thanks.
In detail: do_swap_page returns -ENOMEM when memory allocation fails; the
return value will in turn be returned by handle_pte_fault and handle_mm_fault
to this code in do_page_fault:
switch (handle_mm_fault(mm, vma, address, write)) {
case VM_FAULT_MINOR:
tsk->min_flt++;
break;
case VM_FAULT_MAJOR:
tsk->maj_flt++;
break;
case VM_FAULT_SIGBUS:
goto do_sigbus;
case VM_FAULT_OOM:
goto out_of_memory;
default:
BUG();
}
So on OOM we can get a BUG. Since do_file_page does this:
if (err == -ENOMEM)
return VM_FAULT_OOM;
and other code shows similar behaviour, I think that the attached fix is the
correct one.
--
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
[-- Attachment #2: Fix-mm-return.patch --]
[-- Type: text/x-diff, Size: 302 bytes --]
--- ./mm/memory.c.fix 2004-02-04 20:48:15.000000000 +0100
+++ ./mm/memory.c 2004-02-14 17:59:42.000000000 +0100
@@ -1250,7 +1250,7 @@
mark_page_accessed(page);
pte_chain = pte_chain_alloc(GFP_KERNEL);
if (!pte_chain) {
- ret = -ENOMEM;
+ ret = VM_FAULT_OOM;
goto out;
}
lock_page(page);
next reply other threads:[~2004-02-15 15:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-15 15:47 BlaisorBlade [this message]
2004-02-16 0:01 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200402151647.39907.blaisorblade_spam@yahoo.it \
--to=blaisorblade_spam@yahoo.it \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®