mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Tom Rini <trini@kernel.crashing.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][1/6] A different KGDB stub
Date: Tue, 17 Feb 2004 16:33:12 -0800	[thread overview]
Message-ID: <20040217163312.729c951f.akpm@osdl.org> (raw)
In-Reply-To: <20040218000315.GN16881@smtp.west.cox.net>

Tom Rini <trini@kernel.crashing.org> wrote:
>
> By my read of Andi's email, the kern_do_schedule() gunk is "I really
> don't like this change. It is completely useless because you can get the
> pt_regs as well from the stack.  Please don't add it. George's stub also
> didn't need it."
> 
> But I don't see how it does.  But I'll look again tomorrow.

OK, thanks.  That would be appreciated, if only because the sched.c and
entry.S changes have caused significant patch-conflict hassles in the past,
and they're pretty ugly.

Plus the little fact that the patch which you sent broke all other
architectures: they call schedule() from assembly code, and schedule()
ain't there any more.

I'll have a play with the patches which you sent, and if they don't break
I'll add them to -mm and I'll kludgily fix ppc64 and ia64 (if needed).  Be
aware that I removed the (large amount of) trailing whitespace which they
added.


  reply	other threads:[~2004-02-18  0:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-17 22:02 Tom Rini
2004-02-17 23:50 ` Andrew Morton
2004-02-18  0:03   ` Tom Rini
2004-02-18  0:33     ` Andrew Morton [this message]
2004-02-18  0:39       ` Tom Rini
2004-02-25 17:50       ` Tom Rini
2004-02-18 19:36 ` Pavel Machek
2004-02-18 20:23   ` Tom Rini
  -- strict thread matches above, loose matches on Subject: below --
2004-02-12  0:02 Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040217163312.729c951f.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trini@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®