From: Andrew Morton <akpm@osdl.org>
To: Niraj Kumar <niraj17@iitbombay.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [2.6] UFS2 Read Only Patch
Date: Wed, 18 Feb 2004 01:44:22 -0800 [thread overview]
Message-ID: <20040218014422.7a1144b3.akpm@osdl.org> (raw)
In-Reply-To: <40332F42.9070605@iitbombay.org>
Niraj Kumar <niraj17@iitbombay.org> wrote:
>
> lease apply this patch .
> They provide the bare minimum read-only support for
> ufs2 variant (from FreeBSD 5.x ) of the UFS filesystem .
>
> The patch for 2.6.3 is here :
> http://ufs-linux.sourceforge.net/ufs2/2.6.3/ufs2-read-only-p1.txt
> http://ufs-linux.sourceforge.net/ufs2/2.6.3/ufs2-read-only-p2.txt
ooh, I see you have a mkfs.ufs there. Does it support UFS1 as well?
Does current UFS support little-endian machines? If so, has this code been
tested on a little-endian host? The code _looks_ OK, but one does need to
test...
Has the patched filesystem been regression tested against a UFS1 filesystem?
The patches which you have there are a bit of a disaster coding-style wise.
- Use hard tabs everywhere, not eight-spaces.
- No space before terminating semicolons
-
+ if ( (flags & UFS_TYPE_MASK) == UFS_TYPE_UFS2)
+ {
+ uspi->s_u2_size = fs64_to_cpu(sb, usb->fs_u11.fs_u2.fs_size);
should be
if ((flags & UFS_TYPE_MASK) == UFS_TYPE_UFS2) {
etcetera. See Documentation/CodingStyle.
Thanks.
next prev parent reply other threads:[~2004-02-18 9:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-18 9:24 Niraj Kumar
2004-02-18 9:44 ` Andrew Morton [this message]
2004-02-18 10:37 ` Niraj Kumar
2004-02-20 6:35 ` Niraj Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040218014422.7a1144b3.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=niraj17@iitbombay.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®