From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266997AbUBRXOu (ORCPT ); Wed, 18 Feb 2004 18:14:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266977AbUBRXOt (ORCPT ); Wed, 18 Feb 2004 18:14:49 -0500 Received: from ausmtp01.au.ibm.com ([202.81.18.186]:18308 "EHLO ausmtp01.au.ibm.com") by vger.kernel.org with ESMTP id S266997AbUBRXNr (ORCPT ); Wed, 18 Feb 2004 18:13:47 -0500 From: Rusty Russell To: Linda Xie Cc: John Rose , Rusty Russell , linux-kernel@vger.kernel.org, gregkh@us.ibm.com, Mike Wortman Subject: Re: [PATCH] PPC64 PCI Hotplug Driver for RPA In-reply-to: Your message of "Wed, 18 Feb 2004 13:14:11 MDT." <4033B983.6060809@ltcfwd.linux.ibm.com> Date: Thu, 19 Feb 2004 09:27:18 +1100 Message-Id: <20040218231322.65F7C17DD8@ozlabs.au.ibm.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org In message <4033B983.6060809@ltcfwd.linux.ibm.com> you write: > >Umm, what's this? Checking CONFIG_FOO_MODULE is basically always wrong > >and especially in this case. Just use "rpaphp" always. > > > > > Replaced with > > #define MY_NAME "rpaphp" Or better, remove #define and use KBUILD_MODNAME, which for this file will be rpaphp anyway. Thanks, Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell.