From: Matthew Wilcox <willy@debian.org>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: Matthew Wilcox <willy@debian.org>, linux-kernel@vger.kernel.org
Subject: Re: [RFC] How should delete_resource() handle children?
Date: Thu, 19 Feb 2004 02:20:09 +0000 [thread overview]
Message-ID: <20040219022009.GP11824@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040218174800.0a3183ec.rddunlap@osdl.org>
On Wed, Feb 18, 2004 at 05:48:00PM -0800, Randy.Dunlap wrote:
> Ideally (or if nothing depends on the current behavior), I think it
> should just be an error (return -EINVAL), not a BUG_ON(). I.e.,
> releasing a resource should be an explicit action.
-EBUSY, perhaps?
> Do we know of cases where parents are removed but children need to
> remain? Examples?
I don't know of any in-tree. I was originally just looking at this code
while writing adjust_resource() and insert_resource() and noticed this
corner case.
But now, I was thinking about using the resource management code to handle
the PCI hotplug resource management (which currently is done independently
by each hotplug driver). Since the drivers can be loaded independently
of everything under them, they'd need to use insert_resource() and
remove_resource() to avoid disturbing the child resources.
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
prev parent reply other threads:[~2004-02-19 2:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-10 19:33 Matthew Wilcox
2004-02-19 1:48 ` Randy.Dunlap
2004-02-19 2:12 ` Nick Piggin
2004-02-19 2:07 ` Randy.Dunlap
2004-02-19 2:20 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040219022009.GP11824@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®