mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Gertjan van Wingerde <gwingerde@home.nl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Ext3 and/or SCSI bug?
Date: Thu, 19 Feb 2004 15:42:18 -0800	[thread overview]
Message-ID: <20040219154218.70d63704.akpm@osdl.org> (raw)
In-Reply-To: <200402192011.40854.gwingerde@home.nl>

Gertjan van Wingerde <gwingerde@home.nl> wrote:
>
> Below is an part of my dmesg output that I captured when all of a sudden one
> of my filesystems became mounted read-only (while some heavy reading/
> writing was being performed to that filesystem).
> 
> Can anyone explain to me what is going on here, and why this is happening 
> to me about every 10 days.

I don't know why this:

>  EXT3-fs error (device sdb8): ext3_free_blocks: bit already cleared for block 1142880
>  Aborting journal on device sdb8.

is occurring.  It indicates that the filesystem metadata is corrupted.  You
should force a fsck to fix it up.  It could be a hardware problem (disk,
cable, controller, power supply, or even main memory).

>  bad: scheduling while atomic!
>  Call Trace:
>   [<c012049e>] schedule+0x68e/0x6a0

This part is caused by a minor bug.



ext3_error() sleeps, so don't call it with the lock held.


---

 25-akpm/fs/ext3/balloc.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff -puN fs/ext3/balloc.c~ext3-schedule-inside-lock-fix fs/ext3/balloc.c
--- 25/fs/ext3/balloc.c~ext3-schedule-inside-lock-fix	Thu Feb 19 15:37:04 2004
+++ 25-akpm/fs/ext3/balloc.c	Thu Feb 19 15:38:16 2004
@@ -239,9 +239,10 @@ do_more:
 		BUFFER_TRACE(bitmap_bh, "clear bit");
 		if (!ext3_clear_bit_atomic(sb_bgl_lock(sbi, block_group),
 						bit + i, bitmap_bh->b_data)) {
-			ext3_error (sb, __FUNCTION__,
-				      "bit already cleared for block %lu", 
-				      block + i);
+			jbd_unlock_bh_state(bitmap_bh);
+			ext3_error(sb, __FUNCTION__,
+				"bit already cleared for block %lu", block + i);
+			jbd_lock_bh_state(bitmap_bh);
 			BUFFER_TRACE(bitmap_bh, "bit already cleared");
 		} else {
 			dquot_freed_blocks++;

_


      reply	other threads:[~2004-02-19 23:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-19 19:11 Gertjan van Wingerde
2004-02-19 23:42 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040219154218.70d63704.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=gwingerde@home.nl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®