From: Sam Ravnborg <sam@ravnborg.org>
To: Christoph Hellwig <hch@infradead.org>,
Krzysztof Benedyczak <golbi@mat.uni.torun.pl>,
linux-kernel@vger.kernel.org,
Manfred Spraul <manfred@colorfullife.com>,
Michal Wronski <wrona@mat.uni.torun.pl>
Subject: Re: [RFC][PATCH] 2/6 POSIX message queues
Date: Thu, 19 Feb 2004 20:07:20 +0100 [thread overview]
Message-ID: <20040219190720.GA2421@mars.ravnborg.org> (raw)
In-Reply-To: <20040219145331.B23685@infradead.org>
On Thu, Feb 19, 2004 at 02:53:31PM +0000, Christoph Hellwig wrote:
> > +#ifndef _LINUX_MQUEUE_H
> > +#define _LINUX_MQUEUE_H
> > +
> > +#define MQ_PRIO_MAX 32768
> > +
> > +typedef int mqd_t;
> > +
> > +struct mq_attr {
> > + long mq_flags; /* message queue flags */
> > + long mq_maxmsg; /* maximum number of messages */
> > + long mq_msgsize; /* maximum message size */
> > + long mq_curmsgs; /* number of messages currently queued */
> > +};
> > +
> > +#define NOTIFY_NONE 0
> > +#define NOTIFY_WOKENUP 1
> > +#define NOTIFY_REMOVED 2
> > +
> > +#ifdef __KERNEL__
> > +#include <linux/types.h>
> > +#include <linux/time.h>
>
> This looks like you want glibc to include it, please don't - add a copy
> without the kernel part to glibc instead.
In the previous threads about this the concept of kernel-only and shared
user and kernel headers has been seen as a good solution.
So a split in a kernel-only part, and another kernel+user part seems more
worth-while. And less error-prone.
Maybe something like:
mqueue.h for kernel-only
mqueue_abi.h for kernel+user
Sam
next prev parent reply other threads:[~2004-02-19 18:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-19 14:28 Krzysztof Benedyczak
2004-02-19 14:53 ` Christoph Hellwig
2004-02-19 19:07 ` Sam Ravnborg [this message]
2004-02-19 19:44 ` Manfred Spraul
2004-02-20 13:55 Arnd Bergmann
2004-02-20 18:11 ` Krzysztof Benedyczak
2004-02-22 12:23 ` Arnd Bergmann
2004-02-22 15:12 Manfred Spraul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040219190720.GA2421@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=golbi@mat.uni.torun.pl \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=wrona@mat.uni.torun.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®