From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Jonathan Brown <jbrown@emergence.uk.net>
Cc: linux-kernel@vger.kernel.org, jsimmons@infradead.org
Subject: Re: Double fb_console_init call during do_initcalls
Date: Fri, 20 Feb 2004 10:38:51 -0800 [thread overview]
Message-ID: <20040220103851.3d27f5ab.rddunlap@osdl.org> (raw)
In-Reply-To: <4035F9AE.6060001@emergence.uk.net>
On Fri, 20 Feb 2004 12:12:30 +0000 Jonathan Brown <jbrown@emergence.uk.net> wrote:
| fb_console_init gets called twice during do_initcalls. Should it be
| called from vty_init or as its own initcall? If it should be its own
| initcall then can it be moved up the list to occur sooner? I think it
| looks better if the fb kicks in as early as possible.
|
|
| [<c01d09cc>] take_over_console+0x14a/0x1c9
| [<c031e4c5>] fb_console_init+0x2b/0x59
| [<c031cde4>] vty_init+0xc9/0xd3
| [<c031c5b1>] tty_init+0x234/0x23c
| [<c0310610>] do_initcalls+0x32/0x80
| [<c01050a6>] init+0x2f/0x109
| [<c0105077>] init+0x0/0x109
| [<c0106a81>] kernel_thread_helper+0x5/0xb
| Console: switching to colour frame buffer device 128x48
|
|
| [<c01d09cc>] take_over_console+0x14a/0x1c9
| [<c031e4c5>] fb_console_init+0x2b/0x59
| [<c0310610>] do_initcalls+0x32/0x80
| [<c01050a6>] init+0x2f/0x109
| [<c0105077>] init+0x0/0x109
| [<c0106a81>] kernel_thread_helper+0x5/0xb
| Console: switching to colour frame buffer device 128x48
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Ugh. fb_console_init() can be called by
drivers/char/vt.c (one initcall) or drivers/video/fbmem.c or
drivers/video/console/fbcon.c (<-- module_init/initcall).
It definitely wants to be cleaned up, but changing initcall
order can be "fragile". Have you tried/tested it?
Or maybe James Simmons has some updates for this.
--
~Randy
next prev parent reply other threads:[~2004-02-20 18:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-20 12:12 Jonathan Brown
2004-02-20 18:38 ` Randy.Dunlap [this message]
2004-02-20 19:21 ` James Simmons
2004-02-20 23:02 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040220103851.3d27f5ab.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=jbrown@emergence.uk.net \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®