From: "Bill Rugolsky Jr." <brugolsky@telemetry-investments.com>
To: torvalds@osdl.org, akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, brugolsky@telemetry-investments.com
Subject: [PATCH][3/4] poll()/select() timeout behavior
Date: Fri, 20 Feb 2004 16:03:24 -0500 [thread overview]
Message-ID: <20040220210324.GD1912@ti19.telemetry-investments.com> (raw)
This patch changes select() and poll() to not wait forever when a valid,
but large timeout value is supplied. The SUSv3 manual page for select(2)
states:
"If the timeout argument specifies a timeout interval greater than the
implementation-defined maximum value, the maximum value shall be used as
the actual timeout value."
Both select() and poll() have a well-defined mechanism to wait forever,
so there is no need for the existing behavior.
Please apply.
Bill Rugolsky
--- linux/fs/select.c 2004-02-20 14:27:24.784616879 -0500
+++ linux/fs/select.c 2004-02-20 14:27:28.264660774 -0500
@@ -316,6 +316,8 @@
if ((unsigned long) sec < (MAX_SCHEDULE_TIMEOUT-1) / HZ - 1) {
timeout = ROUND_UP(usec, 1000000/HZ);
timeout += sec * (unsigned long) HZ;
+ } else {
+ timeout = MAX_SCHEDULE_TIMEOUT-1;
}
}
@@ -476,7 +478,7 @@
if (seconds <= (MAX_SCHEDULE_TIMEOUT-2) / HZ - 1)
timeout += seconds*HZ;
else
- timeout = MAX_SCHEDULE_TIMEOUT;
+ timeout = MAX_SCHEDULE_TIMEOUT-1;
}
}
next reply other threads:[~2004-02-20 21:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-20 21:03 Bill Rugolsky Jr. [this message]
2004-02-20 21:55 ` Richard B. Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040220210324.GD1912@ti19.telemetry-investments.com \
--to=brugolsky@telemetry-investments.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®