From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261406AbUBTWv0 (ORCPT ); Fri, 20 Feb 2004 17:51:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261426AbUBTWvZ (ORCPT ); Fri, 20 Feb 2004 17:51:25 -0500 Received: from gprs151-132.eurotel.cz ([160.218.151.132]:27010 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S261406AbUBTWsr (ORCPT ); Fri, 20 Feb 2004 17:48:47 -0500 Date: Fri, 20 Feb 2004 23:48:36 +0100 From: Pavel Machek To: Marcelo Tosatti Cc: Willy Tarreau , linux-kernel@vger.kernel.org Subject: Re: Linux 2.4.25-rc4 Message-ID: <20040220224836.GA32153@elf.ucw.cz> References: <20040218055744.GC15660@alpha.home.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > On Wed, Feb 18, 2004 at 02:11:24AM -0300, Marcelo Tosatti wrote: > > > Here goes release candidate 4, including a few small fixes. > > > > > > If nothing bad shows up, this will become final. > > > > Well, I would have liked to see the ACPI poweroff fix I sent a few days ago, > > but Len said he doesn't have time to review it this week. It's a shame since > > at least two of my machines which powered off correctly with very older ACPI > > versions now need it, so I don't think I'm the only one in this case :-( > > > > Other than that, I'm fairly happy with at least -rc2 (not tested latest > > releases yet). > > Hi Willy, > > Your fix looks ok. I dont think calling acpi_system_save_state(S5) can > cause any breakage. Len? I bet it will create "machine will reboot instead of poweroff" on some strange machine.... Perhaps it fixes more machines than it breaks, but it will probably break some. Pavel -- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?]