mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Hindley <mark@hindley.uklinux.net>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] 2.6.3 fix 8250_pnp resource allocation
Date: Sat, 21 Feb 2004 14:28:04 +0000	[thread overview]
Message-ID: <20040221142804.GA5292@titan.home.hindley.uklinux.net> (raw)

Hi,

Patch below to ensure that 8250_pnp sets necessary flags so that 8250
driver will reserve ioports.

Before, I was logging errors like

Feb 20 08:42:37 titan kernel: Trying to free nonexistent resource <000003e8-000003ef>

on module unload.

Mark


diff -u ../linux-2.6.3/drivers/serial/8250_pnp.c drivers/serial/8250_pnp.c
--- ../linux-2.6.3/drivers/serial/8250_pnp.c	Sat Feb 21 12:18:33 2004
+++ drivers/serial/8250_pnp.c	Sat Feb 21 14:18:38 2004
@@ -21,8 +21,10 @@
 #include <linux/pnp.h>
 #include <linux/string.h>
 #include <linux/kernel.h>
+#include <linux/tty.h>
 #include <linux/serial.h>
 #include <linux/serialP.h>
+#include <linux/serial_core.h>
 
 #include <asm/bitops.h>
 #include <asm/byteorder.h>
@@ -408,7 +410,7 @@
 	       serial_req.port, serial_req.irq, serial_req.io_type);
 #endif
 
-	serial_req.flags = ASYNC_SKIP_TEST | ASYNC_AUTOPROBE;
+	serial_req.flags = UPF_SKIP_TEST | UPF_AUTOPROBE  | UPF_RESOURCES;
 	serial_req.baud_base = 115200;
 	line = register_serial(&serial_req);
 

             reply	other threads:[~2004-02-21 14:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-21 14:28 Mark Hindley [this message]
2004-02-21 14:53 ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040221142804.GA5292@titan.home.hindley.uklinux.net \
    --to=mark@hindley.uklinux.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®