From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261601AbUBUStM (ORCPT ); Sat, 21 Feb 2004 13:49:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261603AbUBUStM (ORCPT ); Sat, 21 Feb 2004 13:49:12 -0500 Received: from gprs159-17.eurotel.cz ([160.218.159.17]:50560 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S261601AbUBUStJ (ORCPT ); Sat, 21 Feb 2004 13:49:09 -0500 Date: Sat, 21 Feb 2004 19:48:57 +0100 From: Pavel Machek To: "Eric W. Biederman" Cc: Linus Torvalds , Stephen Hemminger , ak@suse.de, linux-kernel@vger.kernel.org Subject: Re: kernel/microcode.c error from new 64bit code Message-ID: <20040221184857.GE277@elf.ucw.cz> References: <20040218145218.6bae77b5@dell_ss3.pdx.osdl.net> <20040221141608.GB310@elf.ucw.cz> <20040221173449.GA277@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > On Sat, 21 Feb 2004, Pavel Machek wrote: > > > > > > I'm just afraid that someone will mail you a patch replacing that with > > > >> 32 and you'll overlook it. > > > > Well, the good news is that ">> 32" should cause gcc to complain with a > > big warning (exactly because it's undefined brhaviour on a 32-bit > > architecture), so I don't think it's easy to overlook. > > What is wrong with the original? > > - wrmsr(MSR_IA32_UCODE_WRITE, (unsigned int)(uci->mc->bits), 0); > > I don't see how anything else could be correct. > > Either we have high bits we need to worry about in 32bit mode, in which > case the 32bit variant is wrong. Or we don't have high bits to worry > about in which case attempting to set them is wrong. I believe that driver is now shared between i386 and x86-64. Pavel -- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?]