From: viro@parcelfarce.linux.theplanet.co.uk
To: Mike Strosaker <strosake@austin.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch-specific callout in panic()
Date: Mon, 23 Feb 2004 05:54:15 +0000 [thread overview]
Message-ID: <20040223055415.GY31035@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <40398BFE.1040300@austin.ibm.com>
On Sun, Feb 22, 2004 at 11:13:34PM -0600, Mike Strosaker wrote:
> Hello, All:
>
> There are some ppc64-specific actions that should be taken upon a
> kernel panic. Rather than adding a new #ifdef in panic(), it seems to
> me that it would be worthwhile to add a single callout, and move the
> arch-specific code out to the arch subtrees. Does this seem reasonable,
> or should another #ifdef be added in panic() to perform the ppc64-
> specific actions?
Don't do it that way. Add a weak alias to empty function and override it
on ppc64 by defining a function with the same name.
See how cond_syscall() is done - similar trick will work here. There's
no need to mess with the architectures that do not use your hook.
next prev parent reply other threads:[~2004-02-23 5:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-23 5:13 Mike Strosaker
2004-02-23 5:34 ` Andrew Morton
2004-02-23 18:33 ` Mike Strosaker
2004-02-24 4:25 ` Keith Owens
2004-02-23 5:54 ` viro [this message]
2004-02-23 9:25 Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040223055415.GY31035@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=strosake@austin.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®