From: Andrew Morton <akpm@osdl.org>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: torvalds@osdl.org, piggin@cyberone.com.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix shmat
Date: Mon, 23 Feb 2004 12:57:30 -0800 [thread overview]
Message-ID: <20040223125730.18a8ed5d.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0402232127250.13421-100000@dbl.q-ag.de>
Manfred Spraul <manfred@colorfullife.com> wrote:
>
> On Mon, 23 Feb 2004, Linus Torvalds wrote:
> >
> > Please. Maybe it might even be worth-while renaming it to "do_sys_shmat()"
> > to make it clear that it's not a "sys_xxx()" at all.
> >
>
> Below is a patch that renames sys_shmat to do_shmat. Additionally, I've
> replaced the cond_syscall with a conditional inline function.
It doesn't update arch/mips/kernel/scall64-64.S and
arch/mips/kernel/scall64-n32.S?
I'd be inclined to leave it as sys_shmat(). It is logically a syscall, and
the fact that everyone except mips (and ia64) sticks a multiplexer in front
of it is a sad historical note.
It's simply a matter of getting the appropriate prototype in scope for all
the C callers. For now, I'd be inclined to bung the prototype in kernel.h,
because Randy's syscalls.h patches will fix all this for real in a week or
two.
next prev parent reply other threads:[~2004-02-23 20:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1AvBNO-0004QF-00@bkwatch.colorfullife.com>
2004-02-23 18:15 ` Manfred Spraul
2004-02-23 18:21 ` Randy.Dunlap
2004-02-23 18:36 ` Linus Torvalds
2004-02-23 20:33 ` Manfred Spraul
2004-02-23 20:57 ` Andrew Morton [this message]
2004-02-23 23:29 ` Anton Blanchard
2004-02-23 19:02 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040223125730.18a8ed5d.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=piggin@cyberone.com.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®