Re: Badness in pci_find_subsys

[Greg KH <greg@kroah.com>]

On Mon, Feb 23, 2004 at 08:30:44AM +0100, Martin wrote:
> On Monday 23 February 2004 06:39, Robin Rosenberg wrote:
> 
> > > I was checking the pci documentation and it said under the heading
> > > Obsolete function pci_find_subsys() - Superseded by pci_get_subsys() as
> > > the former is not Hot plug safe. Could this be related to the problem
> >
> > You WHAT? Read the documentation! :-) I thought the ones calling the
> > function should do that.
> 
> Reading the documentation (ie. source code) it appears the problem is 
> triggered by the line
> 
> WARN_ON(in_interrupt());
> 
> Looks like the driver calls pci_find_subsys() from inside an interrupt on 
> occasions which apparently it shouldn't. The problem seems to be on 
> nvidia's side, not kernel development. I have emailed nvidia about it some 
> time ago, so far no reaction... 

This is correct, that function should not be called from within an
interrupt.  That is just stupid programming...

thanks,

greg k-h