From: viro@parcelfarce.linux.theplanet.co.uk
To: Ian Wienand <ianw@gelato.unsw.edu.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] devpts_fs.h fails with "error: parameter name omitted"
Date: Tue, 24 Feb 2004 03:00:57 +0000 [thread overview]
Message-ID: <20040224030056.GN31035@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040224024942.GG1200@cse.unsw.EDU.AU>
On Tue, Feb 24, 2004 at 01:49:42PM +1100, Ian Wienand wrote:
> On Tue, Feb 24, 2004 at 02:24:24AM +0000, viro@parcelfarce.linux.theplanet.co.uk wrote:
> > That part makes sense. Previous one doesn't.
>
> Is that by convention or is leaving out the parameter name in the
> prototype standardised somewhere?
It's valid C and it's pretty common style. Both that and leaving the
names in prototype can be found in the kernel and CodingStyle is OK
with either variant. Which makes the change gratitious.
next prev parent reply other threads:[~2004-02-24 3:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-24 2:16 Ian Wienand
2004-02-24 2:24 ` viro
2004-02-24 2:49 ` Ian Wienand
2004-02-24 3:00 ` viro [this message]
2004-02-24 4:31 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040224030056.GN31035@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=ianw@gelato.unsw.edu.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®