From: Bart De Schuymer <bdschuym@pandora.be>
To: "Simon Barber" <simon@instant802.com>,
"Kernel Mailing List" <linux-kernel@vger.kernel.org>,
<netdev@oss.sgi.com>
Subject: Re: Problem with ebtables target that changes frame protocol
Date: Tue, 24 Feb 2004 22:47:20 +0100 [thread overview]
Message-ID: <200402242247.20875.bdschuym@pandora.be> (raw)
In-Reply-To: <AC8C1F46CD753F4AAC8F890E35A9EB461C66EB@webmail.instant802.com>
On Monday 23 February 2004 23:41, Simon Barber wrote:
> I have written an ebtables target that changes the ethernet protocol of
> a received frame (it runs in the broute chain). I have been working on
> 2.4.21 sources - Unfortunately inside netif_rx the skb->protocol is
> looked at before the bridge code is called - and then acted upon after.
> Hence if the bridge code changes the protocol the incorrect protocol is
> used to process the frame.
As the variable type is only used after the bridge code, I think it is best to
postpone the initialization of type until after the bridge code. This is of
course of no concern to the standard 2.4 kernel (as ebtables isn't in 2.4).
This problem exists in the 2.6 kernel, however.
I'll make a fix for 2.6 later, unless someone beats me to it. I'm kind of busy
at the moment.
cheers,
Bart
parent reply other threads:[~2004-02-24 21:47 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <AC8C1F46CD753F4AAC8F890E35A9EB461C66EB@webmail.instant802.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200402242247.20875.bdschuym@pandora.be \
--to=bdschuym@pandora.be \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=simon@instant802.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®