From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261347AbUBYOhb (ORCPT ); Wed, 25 Feb 2004 09:37:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261346AbUBYOha (ORCPT ); Wed, 25 Feb 2004 09:37:30 -0500 Received: from khan.acc.umu.se ([130.239.18.139]:3318 "EHLO khan.acc.umu.se") by vger.kernel.org with ESMTP id S261347AbUBYOgo (ORCPT ); Wed, 25 Feb 2004 09:36:44 -0500 Date: Wed, 25 Feb 2004 15:36:39 +0100 From: David Weinehall To: Jakub Bogusz Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] 2.6.3 - fix for undefined mdelay in 3c505 Message-ID: <20040225143639.GA17140@khan.acc.umu.se> Mail-Followup-To: Jakub Bogusz , linux-kernel@vger.kernel.org References: <20040225141101.GK16814@gruby.cs.net.pl> <20040225142434.GZ17140@khan.acc.umu.se> <20040225143254.GM16814@gruby.cs.net.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040225143254.GM16814@gruby.cs.net.pl> User-Agent: Mutt/1.4.1i X-Accept-Language: Swedish, English X-GPG-Fingerprint: 7ACE 0FB0 7A74 F994 9B36 E1D1 D14E 8526 DC47 CA16 X-GPG-Key: http://www.acc.umu.se/~tao/files/pubkey_dc47ca16.gpg.asc Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 25, 2004 at 03:32:55PM +0100, Jakub Bogusz wrote: > On Wed, Feb 25, 2004 at 03:24:34PM +0100, David Weinehall wrote: > > On Wed, Feb 25, 2004 at 03:11:01PM +0100, Jakub Bogusz wrote: > > > This patch fixes undefined mdelay() in 3c505 driver - at least on alpha > > > (maybe on other archs is included by some other headers, > > > but on alpha it isn't) there was warning: > > > > > > *** Warning: "mdelay" [drivers/net/3c505.ko] undefined! > > > > You aren't seriously using a 3c505 on an Alpha, are you?! > > No, I'm not. Just trying to compile kernel with "most-module/most-yes" > config ;) Good, got a little worried there... > Kconfig allows to enable this, so it should build cleanly, right? Oh, indeed, and killing warnings is rarely a bad thing (it can sometimes be harmful though, if it hides more serious problems. That's not the case here, however). Regards: David Weinehall -- /) David Weinehall /) Northern lights wander (\ // Maintainer of the v2.0 kernel // Dance across the winter sky // \) http://www.acc.umu.se/~tao/ (/ Full colour fire (/