From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262659AbUBZDsW (ORCPT ); Wed, 25 Feb 2004 22:48:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262693AbUBZDsW (ORCPT ); Wed, 25 Feb 2004 22:48:22 -0500 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:30930 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S262659AbUBZDPy (ORCPT ); Wed, 25 Feb 2004 22:15:54 -0500 Date: Thu, 26 Feb 2004 03:15:53 +0000 From: viro@parcelfarce.linux.theplanet.co.uk To: Andrew Morton Cc: bgerst@didntduck.org, torvalds@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Clean up sys_ioperm stubs Message-ID: <20040226031553.GF31035@parcelfarce.linux.theplanet.co.uk> References: <403D5F32.4080805@quark.didntduck.org> <20040226030523.GE31035@parcelfarce.linux.theplanet.co.uk> <20040225191140.36288919.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040225191140.36288919.akpm@osdl.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 25, 2004 at 07:11:40PM -0800, Andrew Morton wrote: > viro@parcelfarce.linux.theplanet.co.uk wrote: > > > > On Wed, Feb 25, 2004 at 09:51:30PM -0500, Brian Gerst wrote: > > > Remove stubs for sys_ioperm for non-x86 arches, using sys_ni_syscall > > > instead where applicable. > > > > I have better suggestion: make sys_ioperm() a cond_syscall(). Then kill > > its implementation on all platforms where it just returns -ENOSYS. > > Why is that better? Sticking a pointer to the not-implemented-syscall into > the syscall table is pretty darn explicit. No chance of reuse. BTW, #define __NR_ioperm /* 101 */ is asking for trouble. You get the symbol defined (so that will fool any ifdef) and it expands to something completely bogus.