From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262763AbUBZKyE (ORCPT ); Thu, 26 Feb 2004 05:54:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262764AbUBZKyE (ORCPT ); Thu, 26 Feb 2004 05:54:04 -0500 Received: from gruby.cs.net.pl ([62.233.142.99]:27155 "EHLO gruby.cs.net.pl") by vger.kernel.org with ESMTP id S262763AbUBZKx7 (ORCPT ); Thu, 26 Feb 2004 05:53:59 -0500 Date: Thu, 26 Feb 2004 11:53:57 +0100 From: Jakub Bogusz To: Christoph Hellwig , linux-kernel@vger.kernel.org Subject: Re: i2c on alpha - used but not available in 2.6.3 Message-ID: <20040226105357.GF19602@gruby.cs.net.pl> References: <20040225160833.GA5803@gruby.cs.net.pl> <20040225161441.A6161@infradead.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="gKMricLos+KVdGMg" Content-Disposition: inline In-Reply-To: <20040225161441.A6161@infradead.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org --gKMricLos+KVdGMg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 25, 2004 at 04:14:41PM +0000, Christoph Hellwig wrote: > On Wed, Feb 25, 2004 at 05:08:33PM +0100, Jakub Bogusz wrote: > > I checked that adding including of drivers/i2c/Kconfig to arch/alpha/Kconfig > > everything build and all remaining unresolved symbols fade away. > > I'd just switch alpha to use drivers/Kconfig Like in the attached patch? I found few more differences: - beside drivers/i2c there was no drivers/misc and drivers/telephony in alpha/Kconfig - was this intentional or accidental? drivers/misc currently contains only IBM_ASM, which looks like some hardware-specific driver - maybe it should be available only on some arch(s)? - on alpha drivers/parport was placed in "System setup" menu - but I suppose it can be moved to standard location without problems - drivers/message/fusion was included only conditionaly, depending on PCI option (in drivers/Kconfig it's unconditional). If message/fusion requires PCI, maybe it should have "depends on PCI" in its Kconfig? -- Jakub Bogusz http://cyber.cs.net.pl/~qboosh/ PLD Team http://www.pld-linux.org/ --gKMricLos+KVdGMg Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="linux-alpha-use-device-Kconfig.patch" --- linux-2.6.3/arch/alpha/Kconfig.orig 2004-02-24 11:07:49.000000000 +0100 +++ linux-2.6.3/arch/alpha/Kconfig 2004-02-26 11:13:49.000000000 +0100 @@ -596,51 +596,12 @@ source "fs/Kconfig.binfmt" -source "drivers/parport/Kconfig" - endmenu -source "drivers/base/Kconfig" - -source "drivers/mtd/Kconfig" - -source "drivers/pnp/Kconfig" - -source "drivers/block/Kconfig" - -source "drivers/md/Kconfig" - -source "drivers/ide/Kconfig" - -source "drivers/scsi/Kconfig" - -if PCI -source "drivers/message/fusion/Kconfig" -endif - -source "drivers/ieee1394/Kconfig" - -source "net/Kconfig" - -source "drivers/isdn/Kconfig" - -source "drivers/cdrom/Kconfig" - -source "drivers/input/Kconfig" - -source "drivers/char/Kconfig" - -#source drivers/misc/Config.in -source "drivers/media/Kconfig" +source "drivers/Kconfig" source "fs/Kconfig" -source "drivers/video/Kconfig" - -source "sound/Kconfig" - -source "drivers/usb/Kconfig" - source "arch/alpha/oprofile/Kconfig" menu "Kernel hacking" --gKMricLos+KVdGMg--