mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Anderson <andmike@us.ibm.com>
To: Ben Collins <bcollins@debian.org>
Cc: Andrew Morton <akpm@osdl.org>,
	James.Bottomley@steeleye.com, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org
Subject: Re: [BK PATCH] SCSI host num allocation improvement
Date: Fri, 27 Feb 2004 08:33:41 -0800	[thread overview]
Message-ID: <20040227163341.GB1424@beaverton.ibm.com> (raw)
In-Reply-To: <20040227030428.GA707@phunnypharm.org>

Ben Collins [bcollins@debian.org] wrote:
>  static void scsi_host_cls_release(struct class_device *class_dev)
>  {
> +	down(&host_num_lock);
> +	idr_remove(&allocated_hosts, class_to_shost(class_dev)->host_no);
> +	up(&host_num_lock);
>  	put_device(&class_to_shost(class_dev)->shost_gendev);
>  }
>  

Should the idr_remove be done in scsi_host_dev_release instead? We
really should not make this number available until everyone is done with
this host.

-andmike
--
Michael Anderson
andmike@us.ibm.com


  reply	other threads:[~2004-02-27 16:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-26 23:54 Ben Collins
2004-02-27  1:19 ` Andrew Morton
2004-02-27  1:37   ` Andrew Morton
2004-02-27  2:09     ` Ben Collins
2004-02-27  2:32     ` Ben Collins
2004-02-27  2:51       ` Andrew Morton
2004-02-27  2:50     ` Ben Collins
2004-02-27  3:04     ` Ben Collins
2004-02-27 16:33       ` Mike Anderson [this message]
2004-02-27 22:30         ` Andrew Morton
2004-02-27 18:51   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040227163341.GB1424@beaverton.ibm.com \
    --to=andmike@us.ibm.com \
    --cc=James.Bottomley@steeleye.com \
    --cc=akpm@osdl.org \
    --cc=bcollins@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®