From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Christoph Hellwig <hch@infradead.org>
Cc: hch@infradead.org, hch@lst.de, akpm@osdl.org, linus@osdl.org,
anton@samba.org, paulus@samba.org, axboe@suse.de,
piggin@cyberone.com.au, viro@parcelfarce.linux.theplanet.co.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iSeries virtual disk
Date: Sat, 28 Feb 2004 00:26:14 +1100 [thread overview]
Message-ID: <20040228002614.2b4ff994.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20040227121300.B31544@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 919 bytes --]
On Fri, 27 Feb 2004 12:13:00 +0000 Christoph Hellwig <hch@infradead.org> wrote:
>
> That's not how I read your code. But to actually understand what it's
> doing we need to know what open_data.max_disk actually is.
>
> is this the maximum number of disks currently configured (if so the
> interface would be absolutely braindead, but the current code would
> match your above description although beein rather confusing).
It is the highest index of all the configured disks. Did you read my
previous email? If disks 1 2 4 and 7 are configured, the
open_data.max_disk will be 7. If the admin thena adds disk 23, the next
time we probe (by calling the HV open interface) the returned max_disk
will be 23.
I do not apologise for braindead interfaces in code I didn't write ...
In this case I just have to use it.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-02-27 13:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040123163504.36582570.sfr@canb.auug.org.au>
[not found] ` <20040122221136.174550c3.akpm@osdl.org>
2004-02-26 6:23 ` Stephen Rothwell
2004-02-26 7:29 ` Jeff Garzik
2004-02-26 7:40 ` Jens Axboe
2004-02-27 0:44 ` Stephen Rothwell
2004-02-26 7:52 ` Stephen Rothwell
2004-02-26 7:58 ` Jeff Garzik
2004-02-27 0:42 ` Stephen Rothwell
2004-02-27 1:50 ` Jeff Garzik
2004-02-27 2:45 ` Stephen Rothwell
2004-02-27 2:50 ` Jeff Garzik
2004-02-26 9:51 ` Christoph Hellwig
2004-02-27 1:04 ` Stephen Rothwell
2004-02-27 11:32 ` Christoph Hellwig
2004-02-27 11:57 ` Stephen Rothwell
2004-02-27 12:13 ` Christoph Hellwig
2004-02-27 13:26 ` Stephen Rothwell [this message]
2004-02-27 13:37 ` Christoph Hellwig
2004-02-27 13:44 ` Christoph Hellwig
2004-02-27 23:26 ` Stephen Rothwell
2004-02-26 17:35 ` Linus Torvalds
2004-02-27 0:45 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040228002614.2b4ff994.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@osdl.org \
--cc=anton@samba.org \
--cc=axboe@suse.de \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=linus@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=piggin@cyberone.com.au \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®