From: Dave Jones <davej@redhat.com>
To: Andi Kleen <ak@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
yi.zhu@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [start_kernel] Suggest to move parse_args() before trap_init()
Date: Mon, 1 Mar 2004 20:54:26 +0000 [thread overview]
Message-ID: <20040301205426.GA5862@redhat.com> (raw)
In-Reply-To: <p73vfloz45t.fsf@verdi.suse.de>
On Mon, Mar 01, 2004 at 09:46:38PM +0100, Andi Kleen wrote:
> > I think the only problem with this is if we get a fault during
> > parse_args(), the kernel flies off into outer space. So you lose some
> > debuggability when using an early console.
> >
> > But 2.4 does trap_init() after parse_args() and nobody has complained, as
> > did 2.6 until recently. So the change is probably OK.
>
> The standard way to fix this is to add an explicit check for lapic
> to the early argument parsing in setup.c (but keep the __setup so that
> no unknown argument is reported).
This just got me thinking of a sort-of related problem.
Some laptops hang when local apic is enabled, and we couldn't
blacklist them in 2.4 due to us not doing the dmi scan early enough.
Did that get fixed in 2.6 ?
Dave
next prev parent reply other threads:[~2004-03-01 20:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-01 9:36 Zhu, Yi
2004-03-01 10:56 ` Andrew Morton
[not found] ` <20040301025637.338f41cf.akpm@osdl.org.suse.lists.linux.kernel>
2004-03-01 20:46 ` Andi Kleen
2004-03-01 20:54 ` Dave Jones [this message]
2004-03-01 21:14 ` Andi Kleen
2004-03-01 21:15 ` Dave Hansen
2004-03-02 1:49 Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040301205426.GA5862@redhat.com \
--to=davej@redhat.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®