mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Keith Duthie <psycho@albatross.co.nz>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: APM suspend causes uninterruptible sleep
Date: Tue, 2 Mar 2004 22:38:22 +0100	[thread overview]
Message-ID: <20040302213822.GB531@openzaurus.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.53.0402272054010.164@loki.albatross.co.nz>

Hi!

> Between alsa-driver 0.9.4 and alsa-driver 0.9.5 the change below was made.
> Since then, suspending with a program outputting to the pcm device
> causes that program to enter the uninterruptible sleep state. Reverting
> this patch fixes the problem. The problem exists in 0.9.5 through 1.0.2c.
> 
> This problem affects kernel 2.6.3; applying the reversion of this patch
> fixes it.

This should really use driver model...

> 
> diff -urN alsa-driver-0.9.4/alsa-kernel/isa/cs423x/cs4231_lib.c alsa-driver-0.9.5/alsa-kernel/isa/cs423x/cs4231_lib.c
> --- alsa-driver-0.9.4/alsa-kernel/isa/cs423x/cs4231_lib.c	Wed Apr 30 23:53:17 2003
> +++ alsa-driver-0.9.5/alsa-kernel/isa/cs423x/cs4231_lib.c	Tue Jul  8 22:42:09 2003
> @@ -1401,8 +1401,10 @@
> 
>  	switch (rqst) {
>  	case PM_SUSPEND:
> -		if (chip->suspend)
> +		if (chip->suspend) {
> +			snd_pcm_suspend_all(chip->pcm);
>  			(*chip->suspend)(chip);
> +		}
>  		break;
>  	case PM_RESUME:
>  		if (chip->resume)
> 
> -- 
> Just because it isn't nice doesn't make it any less a miracle.
>      http://users.albatross.co.nz/~psycho/     O-   -><-
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms         


  reply	other threads:[~2004-03-04 14:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-27  8:15 Keith Duthie
2004-03-02 21:38 ` Pavel Machek [this message]
     [not found] <1tLo4-3qF-9@gated-at.bofh.it>
2004-02-28  0:18 ` Karol Kozimor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040302213822.GB531@openzaurus.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=psycho@albatross.co.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®