mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Art Haas" <ahaas@airmail.net>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] Compile kernel with GCC-3.5 and without regparm
Date: Tue, 2 Mar 2004 18:23:39 -0600	[thread overview]
Message-ID: <20040303002339.GA20651@artsapartment.org> (raw)

Hi.

I tried to build the kernel with my CVS GCC-3.5 compiler today, and had
all sorts of failures about prototypes not matching. My configuration
had not selected the 'CONFIG_REGPARM' option, so the new '-mregparm=3'
flag wasn't passed to the compiler. That's fine, but the problem is the
FASTCALL macro is unconditionally defined to add an regparm(3)
attribute, making the compiler quite confused. The following small patch
conditionally defines FASTCALL, and allowed my compilation to succeed
either with or without the CONFIG_REGPARM conditional being defined.

I tested this patch by configuring a kernel without the CONFIG_REGPARM
flag, then started the build. Once the build got through building a
couple of files in 'arch/i386/kernel' that had failed previously, I
stopped the build. A cleanup and reconfiguration with the CONFIG_REGPARM
conditional followed, and a new build began. Again, the files in the
same directory compiled fine, so things looked good. I then tried to
build with CONFIG_REGPARM defined and setting CC and HOSTCC to use
my gcc-2.95 compiler, and the files in that directory compiled again
successfully once more.

If this patch is deemed correct, a similar patch for 'asm-um' is
likely necessary as well.

Art Haas

===== include/asm-i386/linkage.h 1.2 vs edited =====
--- 1.2/include/asm-i386/linkage.h	Sun Aug  4 00:44:49 2002
+++ edited/include/asm-i386/linkage.h	Tue Mar  2 17:59:59 2004
@@ -2,7 +2,9 @@
 #define __ASM_LINKAGE_H
 
 #define asmlinkage CPP_ASMLINKAGE __attribute__((regparm(0)))
+#ifdef CONFIG_REGPARM
 #define FASTCALL(x)	x __attribute__((regparm(3)))
+#endif
 
 #ifdef CONFIG_X86_ALIGNMENT_16
 #define __ALIGN .align 16,0x90
-- 
Man once surrendering his reason, has no remaining guard against absurdities
the most monstrous, and like a ship without rudder, is the sport of every wind.

-Thomas Jefferson to James Smith, 1822

             reply	other threads:[~2004-03-03  0:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-03  0:23 Art Haas [this message]
2004-03-03  0:59 ` Andrew Morton
2004-03-03  1:10 ` Brian Gerst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040303002339.GA20651@artsapartment.org \
    --to=ahaas@airmail.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®