From: Andrew Morton <akpm@osdl.org>
To: Luiz Fernando Capitulino <lcapitulino@prefeitura.sp.gov.br>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.4-rc1-mm2
Date: Wed, 3 Mar 2004 16:52:29 -0800 [thread overview]
Message-ID: <20040303165229.131b7601.akpm@osdl.org> (raw)
In-Reply-To: <1078351164.17019.57.camel@telecentrolivre>
Luiz Fernando Capitulino <lcapitulino@prefeitura.sp.gov.br> wrote:
>
> Em Qua, 2004-03-03 às 01:15, Andrew Morton escreveu:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.4-rc1/2.6.4-rc1-mm2/
>
> I got this:
>
> Unable to handle kernel paging request at virtual address c1d61f70
> printing eip:
> c0211f8f
> *pde = 00006063
> *pte = 01d61000
> Oops: 0000 [#1]
> DEBUG_PAGEALLOC
> CPU: 0
> EIP: 0060:[__make_request+671/1184] Not tainted VLI
> EFLAGS: 00010093
> EIP is at __make_request+0x29f/0x4a0
hm, there's a possibility of indirection through an uninitialised variable
there.
--- 25/drivers/block/ll_rw_blk.c~blk-unplug-when-max-request-queued-fix Wed Mar 3 16:03:01 2004
+++ 25-akpm/drivers/block/ll_rw_blk.c Wed Mar 3 16:03:32 2004
@@ -2004,7 +2004,8 @@ EXPORT_SYMBOL(__blk_attempt_remerge);
static int __make_request(request_queue_t *q, struct bio *bio)
{
- struct request *req, *freereq = NULL;
+ struct request *req = NULL;
+ struct request *freereq = NULL;
int el_ret, rw, nr_sectors, cur_nr_sectors, barrier, ra;
sector_t sector;
@@ -2154,7 +2155,7 @@ out:
int nr_queued = q->rq.count[READ] + q->rq.count[WRITE];
if (nr_queued == q->unplug_thresh ||
- req->nr_sectors == q->max_sectors)
+ (req && req->nr_sectors == q->max_sectors))
__generic_unplug_device(q);
}
spin_unlock_irq(q->queue_lock);
_
next prev parent reply other threads:[~2004-03-04 0:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-03 4:15 2.6.4-rc1-mm2 Andrew Morton
2004-03-03 11:32 ` 2.6.4-rc1-mm2 J.A. Magallon
2004-03-03 18:46 ` 2.6.4-rc1-mm2 Adrian Bunk
2004-03-03 16:15 ` 2.6.4-rc1-mm2 (compile stats) John Cherry
2004-03-03 22:33 ` 2.6.4-rc1-mm2 Luiz Fernando Capitulino
2004-03-04 0:52 ` Andrew Morton [this message]
2004-03-04 3:11 ` VM patches in 2.6.4-rc1-mm2 Mike Fedyk
2004-03-04 3:30 ` Andrew Morton
2004-03-04 3:57 ` Mike Fedyk
2004-03-10 8:20 ` Mike Fedyk
2004-03-10 8:36 ` Nick Piggin
2004-03-10 18:57 ` Mike Fedyk
2004-03-10 23:51 ` Nick Piggin
2004-03-11 0:17 ` Mike Fedyk
2004-03-11 0:25 ` Nick Piggin
2004-03-05 17:54 ` 2.6.4-rc1-mm[12] - dm_any_congested issues Valdis.Kletnieks
2004-03-06 3:09 ` Miquel van Smoorenburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040303165229.131b7601.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=lcapitulino@prefeitura.sp.gov.br \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®