From: Chris Wright <chrisw@osdl.org>
To: greg@kroah.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] class_simple cleanup in sg
Date: Wed, 3 Mar 2004 20:06:25 -0800 [thread overview]
Message-ID: <20040303200625.N21045@build.pdx.osdl.net> (raw)
The only spot that seems to care about class_simple_device_add possibly
failing, but it gets the wrong error test.
===== drivers/scsi/sg.c 1.81 vs edited =====
--- 1.81/drivers/scsi/sg.c Fri Feb 6 00:21:23 2004
+++ edited/drivers/scsi/sg.c Wed Mar 3 19:56:13 2004
@@ -1439,7 +1439,7 @@
MKDEV(SCSI_GENERIC_MAJOR, k),
cl_dev->dev, "%s",
disk->disk_name);
- if (NULL == sg_class_member)
+ if (IS_ERR(sg_class_member))
printk(KERN_WARNING "sg_add: "
"class_simple_device_add failed\n");
class_set_devdata(sg_class_member, sdp);
next reply other threads:[~2004-03-04 4:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-04 4:06 Chris Wright [this message]
2004-03-11 1:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040303200625.N21045@build.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®