From: Andrew Morton <akpm@osdl.org>
To: Meelis Roos <mroos@linux.ee>
Cc: linux-kernel@vger.kernel.org
Subject: Re: parport compile error in 2.6.4-r2c (sparc64)
Date: Thu, 4 Mar 2004 03:52:07 -0800 [thread overview]
Message-ID: <20040304035207.5b526efc.akpm@osdl.org> (raw)
In-Reply-To: <Pine.GSO.4.44.0403041144040.2398-100000@math.ut.ee>
Meelis Roos <mroos@linux.ee> wrote:
>
> drivers/parport/parport_sunbpp.c: In function `init_one_port':
> drivers/parport/parport_sunbpp.c:338: warning: passing arg 2 of `request_irq' from incompatible pointer type
> drivers/parport/parport_sunbpp.c: In function `parport_sunbpp_exit':
> drivers/parport/parport_sunbpp.c:387: error: incompatible type for argument 1 of `list_empty'
Does this fix?
diff -puN drivers/parport/parport_sunbpp.c~parport_sunbpp-build-fix drivers/parport/parport_sunbpp.c
--- 25/drivers/parport/parport_sunbpp.c~parport_sunbpp-build-fix 2004-03-04 03:49:57.000000000 -0800
+++ 25-akpm/drivers/parport/parport_sunbpp.c 2004-03-04 03:50:48.000000000 -0800
@@ -44,9 +44,11 @@
#define dprintk(x)
#endif
-static void parport_sunbpp_interrupt(int irq, void *dev_id, struct pt_regs *regs)
+static irqreturn_t parport_sunbpp_interrupt(int irq, void *dev_id,
+ struct pt_regs *regs)
{
parport_generic_irq(irq, (struct parport *) dev_id, regs);
+ return IRQ_HANDLED;
}
static void parport_sunbpp_disable_irq(struct parport *p)
@@ -384,7 +386,7 @@ static int __init parport_sunbpp_init(vo
static void __exit parport_sunbpp_exit(void)
{
- while (!list_empty(port_list)) {
+ while (!list_empty(&port_list)) {
Node *node = list_entry(port_list.next, Node, list);
struct parport *p = node->port;
struct parport_operations *ops = p->ops;
_
next prev parent reply other threads:[~2004-03-04 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-04 9:44 Meelis Roos
2004-03-04 11:52 ` Andrew Morton [this message]
2004-03-04 13:00 ` Meelis Roos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040304035207.5b526efc.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®