Re: [PATCH] PCI Hotplug fixes for 2.6.4-rc1

[Ingo Oeser <ioe-lkml@rameria.de>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Greg,

On Wednesday 03 March 2004 05:21, Greg KH wrote:
> -decl_subsys(pci_hotplug_slots, &hotplug_slot_ktype, NULL);
> -
> +/*
> + * We create a struct subsystem on our own and not use decl_subsys so
> + * we can have a sane name "slots" in sysfs, yet still keep a good
> + * global variable name "pci_hotplug_slots_subsys.
> + * If the decl_subsys() #define ever changes, this declaration will
> + * need to be update to make sure everything is initialized properly.
> + */
> +struct subsystem pci_hotplug_slots_subsys = {
> +	.kset = {
> +		.kobj = { .name = "slots" },
> +		.ktype = &hotplug_slot_ktype,
> +	}
> +};

How about creating a decl_subsys_name() for creating sane names,
like we have for the module parameters?

That whould solve all those problems, since this is used not only once.


Regards

Ingo Oeser

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFARsoBU56oYWuOrkARAk0NAKDWSddUZQSD25ywMKs5zrpcrAJefACgjdV8
1d6axZhMy8k5qCozsrExrBc=
=sQZY
-----END PGP SIGNATURE-----