From: Andrew Morton <akpm@osdl.org>
To: Rui Saraiva <rmps@joel.ist.utl.pt>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.4-rc1-mm2: 3 dumps at __make_request, system freeze
Date: Thu, 4 Mar 2004 11:12:04 -0800 [thread overview]
Message-ID: <20040304111204.6db8bd6e.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0403041834350.28568@joel.ist.utl.pt>
Rui Saraiva <rmps@joel.ist.utl.pt> wrote:
>
> Yesterday I got these 3 dumps (on dmesg) while compiling (on ext3 fs) the
> kernel and some other userland utilities.
Could you please add this?
--- 25/drivers/block/ll_rw_blk.c~blk-unplug-when-max-request-queued-fix Wed Mar 3 16:03:01 2004
+++ 25-akpm/drivers/block/ll_rw_blk.c Wed Mar 3 16:03:32 2004
@@ -2004,7 +2004,8 @@ EXPORT_SYMBOL(__blk_attempt_remerge);
static int __make_request(request_queue_t *q, struct bio *bio)
{
- struct request *req, *freereq = NULL;
+ struct request *req = NULL;
+ struct request *freereq = NULL;
int el_ret, rw, nr_sectors, cur_nr_sectors, barrier, ra;
sector_t sector;
@@ -2154,7 +2155,7 @@ out:
int nr_queued = q->rq.count[READ] + q->rq.count[WRITE];
if (nr_queued == q->unplug_thresh ||
- req->nr_sectors == q->max_sectors)
+ (req && req->nr_sectors == q->max_sectors))
__generic_unplug_device(q);
}
spin_unlock_irq(q->queue_lock);
_
next prev parent reply other threads:[~2004-03-04 19:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-04 18:49 Rui Saraiva
2004-03-04 19:12 ` Andrew Morton [this message]
2004-03-04 21:33 ` Rui Saraiva
2004-03-04 22:26 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040304111204.6db8bd6e.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmps@joel.ist.utl.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®