From: Tom Rini <trini@kernel.crashing.org>
To: George Anzinger <george@mvista.com>
Cc: "Amit S. Kale" <amitkale@emsyssoft.com>,
Pavel Machek <pavel@ucw.cz>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
kgdb-bugreport@lists.sourceforge.net
Subject: Re: [Kgdb-bugreport] [PATCH] Kill kgdb_serial
Date: Thu, 4 Mar 2004 08:17:05 -0700 [thread overview]
Message-ID: <20040304151705.GB26065@smtp.west.cox.net> (raw)
In-Reply-To: <4046780D.7020700@mvista.com>
On Wed, Mar 03, 2004 at 04:27:57PM -0800, George Anzinger wrote:
> Tom Rini wrote:
> >But that's not what you get with kgdb_serial. You get the possibility
> >of serial from point A to B and you will have eth from point B onward,
> >if compiled in. With an arch serial driver you get the possibility of
> >serial (or arch serial or whatever) from point A to B and eth from point
> >B onward, if compiled in.
>
> I don't think we want to switch. Rather we want to say something like: If
> no eth (or other input) options are on the command line then its is serial.
> If eth (or other input) is there, that is what we use.
>
> This does leave open what happens when "eth" is given and we hit a
> breakpoint prior to looking at the command line, but now this just fails so
> we would be hard put to do worse.
This doesn't fail right now, or rather it shouldn't. We would call
kgdb_arch_init() which would set it to 8250 (or arch serial) and go. If
8250||arch serial is compiled in.
> >I think you missed the point. The problem isn't with providing weak
> >functions, the problem is trying to set the function pointer. PPC
> >becomes quite clean since the next step is to kill off
> >PPC_SIMPLE_SERIAL and just have kgdb_read/write_debug_char in the
> >relevant serial drivers.
>
> No, you just set the default at configure time. It is just done in such
> away as to allow it to be overridden.
Which means you have to either c&p this into kgdb_arch_init for every
arch that provides it's own, or (and I've been thinking that this isn't
necessarily a bad idea) standardize on names for the arch serial driver,
and in kernel/kgdb.c::kgdb_entry() do:
#ifdef CONFIG_KGDB_8250
extern ... kgdb8250_serial;
kgdb_serial = &kgdb8250_serial;
#elif CONFIG_KGDB_ARCH_SERIAL
extern ... kgdbarch_serial;
kgdb_serial = &kgdbarch_serial;
#elif CONFIG_KGDB_ETH
extern ... kgdboe_serial;
kgdb_serial = &kgdboe_serial;
#endif
--
Tom Rini
http://gate.crashing.org/~trini/
next prev parent reply other threads:[~2004-03-04 15:17 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-02 21:39 Tom Rini
2004-03-02 22:02 ` [Kgdb-bugreport] " George Anzinger
2004-03-02 22:11 ` Tom Rini
2004-03-02 22:31 ` Pavel Machek
2004-03-02 22:41 ` Tom Rini
2004-03-02 23:00 ` Tom Rini
2004-03-02 23:35 ` Pavel Machek
2004-03-03 15:22 ` Tom Rini
2004-03-03 15:51 ` Pavel Machek
2004-03-03 16:04 ` Tom Rini
2004-03-04 0:34 ` George Anzinger
2004-03-04 5:01 ` Amit S. Kale
2004-03-04 22:02 ` George Anzinger
2004-03-04 22:48 ` Tom Rini
2004-03-02 23:46 ` George Anzinger
2004-03-02 23:52 ` Tom Rini
2004-03-03 0:36 ` George Anzinger
2004-03-03 15:20 ` Tom Rini
2004-03-04 0:30 ` George Anzinger
2004-03-03 5:43 ` Amit S. Kale
2004-03-03 15:16 ` Tom Rini
2004-03-04 0:27 ` George Anzinger
2004-03-04 15:17 ` Tom Rini [this message]
2004-03-04 22:18 ` George Anzinger
2004-03-04 22:49 ` Tom Rini
2004-03-04 4:41 ` Amit S. Kale
2004-03-04 15:27 ` Tom Rini
2004-03-04 23:06 ` George Anzinger
2004-03-04 23:17 ` Tom Rini
2004-03-11 21:33 ` George Anzinger
2004-03-11 22:33 ` Tom Rini
2004-03-11 22:53 ` George Anzinger
2004-03-11 23:00 ` Tom Rini
2004-03-11 23:46 ` George Anzinger
2004-03-12 4:52 ` Amit S. Kale
2004-03-12 4:48 ` Amit S. Kale
2004-03-03 15:26 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040304151705.GB26065@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=amitkale@emsyssoft.com \
--cc=george@mvista.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®