From: Andrew Morton <akpm@osdl.org>
To: Daniel McNeil <daniel@osdl.org>
Cc: linux-kernel@vger.kernel.org, linux-aio@kvack.org, hugh@veritas.com
Subject: Re: [PATCH 2.6.3-mm4] writeback trylock patch
Date: Fri, 5 Mar 2004 17:03:19 -0800 [thread overview]
Message-ID: <20040305170319.7490b880.akpm@osdl.org> (raw)
In-Reply-To: <1078533612.1773.37.camel@ibm-c.pdx.osdl.net>
Daniel McNeil <daniel@osdl.org> wrote:
>
> Here is update to the wb_rwsema patch that adds back the trylock.
> It avoids the hang hugh was seeing by setting encountered_congestion
> if the trylock fails and checking it in sync_sb_inodes(). Hugh
> tested this and did not see the hang.
>
> This prevents non-sync writebacks to from blocking behind sync
> writebacks.
>
> This patch applies to 2.6.4-rc1-mm2.
>
> Thoguhts?
spose so. One concern is with writer throttling: if the caller of write(2)
is simply skipping a large file then it should throttle in
balance_dirty_pages() or block on i_sem I guess. This code is getting
pretty sticky.
Why are you setting wbc->encountered_congestion in sync_sb_inodes()?
And why are you doing a trylock in __filemap_fdatawrite()? That only
affects fadvise(), and probably we want to block in there anyway. It
doesn't matter really but less code is better code.
prev parent reply other threads:[~2004-03-06 1:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-06 0:40 Daniel McNeil
2004-03-06 1:03 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040305170319.7490b880.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=daniel@osdl.org \
--cc=hugh@veritas.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®