From: Andrew Morton <akpm@osdl.org>
To: Thomas Schlichter <thomas.schlichter@web.de>
Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] fix warning about duplicate 'const'
Date: Mon, 8 Mar 2004 16:14:10 -0800 [thread overview]
Message-ID: <20040308161410.49127bdf.akpm@osdl.org> (raw)
In-Reply-To: <200403090043.21043.thomas.schlichter@web.de>
Thomas Schlichter <thomas.schlichter@web.de> wrote:
>
> Hi,
>
> attached is a patch which fixes following wanings:
>
> drivers/ide/ide-tape.c: In function `idetape_setup':
> drivers/ide/ide-tape.c:4701: Warnung: duplicate `const'
> drivers/video/matrox/matroxfb_g450.c: In function `g450_compute_bwlevel':
> drivers/video/matrox/matroxfb_g450.c:129: Warnung: duplicate `const'
> drivers/video/matrox/matroxfb_g450.c:130: Warnung: duplicate `const'
> drivers/video/matrox/matroxfb_maven.c: In function `maven_compute_bwlevel':
> drivers/video/matrox/matroxfb_maven.c:347: Warnung: duplicate `const'
> drivers/video/matrox/matroxfb_maven.c:348: Warnung: duplicate `const'
>
> This is done by removing the 'const' from the temporary variables of the min()
> and max() macros. For me it seems to have no negative impact, so please
> consider applying...
I think there was a reason for those consts in kernel.h's min() and max()
macros, but memory fails me. Linus, do you recall?
next prev parent reply other threads:[~2004-03-09 0:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-08 23:43 Thomas Schlichter
2004-03-09 0:14 ` Andrew Morton [this message]
2004-03-09 0:32 ` Linus Torvalds
2004-03-09 1:17 ` Thomas Schlichter
2004-03-09 1:32 ` Linus Torvalds
2004-03-09 1:35 ` Linus Torvalds
2004-03-10 4:08 ` Keith Duthie
[not found] ` <20040310054918.GB4068@twiddle.net>
2004-03-10 8:10 ` Gabriel Dos Reis
[not found] ` <20040310064001.GA7584@daikokuya.co.uk>
2004-03-10 10:15 ` Joseph S. Myers
2004-03-10 15:43 ` Linus Torvalds
2004-03-10 18:22 ` Richard Henderson
2004-03-10 18:29 ` Andrew Haley
2004-03-10 18:35 ` Paul Koning
2004-03-10 18:37 ` Richard Henderson
2004-03-16 1:46 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040308161410.49127bdf.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.schlichter@web.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®