From: Jens Axboe <axboe@suse.de>
To: Ingo Oeser <ioe-lkml@rameria.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] per-backing dev unplugging #2
Date: Fri, 12 Mar 2004 09:04:46 +0100 [thread overview]
Message-ID: <20040312080446.GB15598@suse.de> (raw)
In-Reply-To: <200403120741.18455.ioe-lkml@rameria.de>
On Fri, Mar 12 2004, Ingo Oeser wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi Jens,
>
> On Thursday 11 March 2004 09:36, Jens Axboe wrote:
> > diff -ur -X /home/axboe/cdrom/exclude /opt/kernel/linux-2.6.4-mm1/kernel/power/pmdisk.c linux-2.6.4-mm1/kernel/power/pmdisk.c
> > --- /opt/kernel/linux-2.6.4-mm1/kernel/power/pmdisk.c 2004-03-11 03:55:28.000000000 +0100
> > +++ linux-2.6.4-mm1/kernel/power/pmdisk.c 2004-03-11 09:07:12.000000000 +0100
> > @@ -859,7 +859,6 @@
> >
> > static void wait_io(void)
> > {
> > - blk_run_queues();
> > while(atomic_read(&io_done))
> > io_schedule();
> > }
> > @@ -895,6 +894,7 @@
> > goto Done;
> > }
> >
> > + rw |= BIO_RW_SYNC;
> > if (rw == WRITE)
> > bio_set_pages_dirty(bio);
> > start_io();
>
> These last 3 lines look bogus. The condition will never trigger.
> Maybe you meant to move the assignment either down or change bio->bi_rw
> instead of rw.
Oops yes, that is bogus. Thanks for cathing that.
--
Jens Axboe
next prev parent reply other threads:[~2004-03-12 8:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-11 8:36 Jens Axboe
2004-03-11 22:44 ` Nathan Scott
2004-03-12 1:23 ` William Lee Irwin III
2004-03-12 6:41 ` Ingo Oeser
2004-03-12 8:04 ` Jens Axboe [this message]
2004-03-12 19:51 ` Chris Mason
2004-03-12 20:03 ` Andrew Morton
2004-03-12 20:02 ` Jens Axboe
2004-03-12 20:34 ` Chris Mason
2004-03-12 20:34 ` Jens Axboe
2004-03-12 20:41 ` Chris Mason
2004-03-12 20:51 ` Jens Axboe
2004-03-14 20:43 ` Chris Mason
2004-03-14 20:47 ` Jens Axboe
2004-03-14 20:57 ` Chris Mason
2004-03-14 21:04 ` Andrew Morton
2004-03-14 21:09 ` Jens Axboe
2004-03-15 21:58 ` Chris Mason
2004-03-12 20:06 ` Chris Mason
2004-03-16 5:22 Jeremy Higdon
2004-03-16 6:36 ` Nick Piggin
2004-03-16 7:20 ` Jeremy Higdon
2004-03-16 7:38 ` Jens Axboe
2004-03-17 0:23 ` Jeremy Higdon
2004-03-16 7:46 ` Nick Piggin
2004-03-16 7:29 ` Jens Axboe
2004-03-16 17:20 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040312080446.GB15598@suse.de \
--to=axboe@suse.de \
--cc=ioe-lkml@rameria.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®