Re: [PATCH] therm_adt7467 update

[Colin Leroy <colin@colino.net>]

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

On 12 Mar 2004 at 09h03, Benjamin Herrenschmidt wrote:

Hi, 

> > Here's a patch that renames the file to therm_adt746x.c and updates
> > Kconfig and Makefile. I also changed a few lines in therm_adt746x.c after
> > renaming it (the patch contains these), the diff is here for clarity:
> 
> Ok, I'll look into getting that upstream. Renaming things is a bit
> nasty (makes big patch for little changes) unless Linus does
> directly a "bk mv" in his tree..

Ok, that's what I thought. 
Would it help if I sent a simpler patch with the modifications to 
therm_adt7467.c, Kconfig and Makefile, and specify to `bk mv` the file after
applying the patch ?

Just in case, here it is. 
Don't forget to rename drivers/macintosh/therm_adt7467.c to 
therm_adt746x.c after :-)

-- 
Colin

[-- Attachment #2: 746x.2.patch --]
[-- Type: application/octet-stream, Size: 1827 bytes --]

diff -u drivers/macintosh/Kconfig drivers/macintosh.new/Kconfig
--- drivers/macintosh/Kconfig	2004-03-11 03:55:26.000000000 +0100
+++ drivers/macintosh.new/Kconfig	2004-03-13 16:30:29.172602112 +0100
@@ -174,8 +174,8 @@
 	  This driver provides some thermostat and fan control for the desktop
 	  G4 "Windtunnel"
 
-config THERM_ADT7467
-	tristate "Support for thermal mgmnt on laptops with ADT 7467 chipset"
+config THERM_ADT746X
+	tristate "Support for thermal mgmnt on laptops with ADT 746x chipset"
 	depends on I2C && I2C_KEYWEST && PPC_PMAC && !PPC_PMAC64
 	help
 	  This driver provides some thermostat and fan control for the
diff -u drivers/macintosh/Makefile drivers/macintosh.new/Makefile
--- drivers/macintosh/Makefile	2004-03-11 03:55:44.000000000 +0100
+++ drivers/macintosh.new/Makefile	2004-03-13 16:30:35.739603776 +0100
@@ -25,4 +25,4 @@
 
 obj-$(CONFIG_THERM_PM72)	+= therm_pm72.o
 obj-$(CONFIG_THERM_WINDTUNNEL)	+= therm_windtunnel.o
-obj-$(CONFIG_THERM_ADT7467)	+= therm_adt7467.o
+obj-$(CONFIG_THERM_ADT746X)	+= therm_adt746x.o
diff -u drivers/macintosh/therm_adt7467.c drivers/macintosh.new/therm_adt7467.c
--- drivers/macintosh/therm_adt7467.c	2004-03-11 03:55:37.000000000 +0100
+++ drivers/macintosh.new/therm_adt7467.c	2004-03-13 16:31:27.164785960 +0100
@@ -49,7 +49,7 @@
 static int fan_speed = -1;
 
 MODULE_AUTHOR("Colin Leroy <colin@colino.net>");
-MODULE_DESCRIPTION("Driver for ADT7467 thermostat in iBook G4");
+MODULE_DESCRIPTION("Driver for ADT746x thermostat in iBook G4 and Powerbook G4 Alu");
 MODULE_LICENSE("GPL");
 
 MODULE_PARM(limit_adjust,"i");
@@ -161,7 +161,7 @@
 }
 
 static struct i2c_driver thermostat_driver = {  
-	.name		="Apple Thermostat ADT7467",
+	.name		="Apple Thermostat ADT746x",
 	.id		=0xDEAD7467,
 	.flags		=I2C_DF_NOTIFY,
 	.attach_adapter	=&attach_thermostat,