From: Adrian Bunk <bunk@fs.tum.de>
To: "Martin J. Bligh" <mbligh@aracnet.com>, nufan_wfk@yahoo.com
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
lse-tech <lse-tech@lists.sourceforge.net>
Subject: [patch] 2.6.4-mjb1: ivtv non-modular compile broken
Date: Sun, 14 Mar 2004 23:20:43 +0100 [thread overview]
Message-ID: <20040314222042.GK14833@fs.tum.de> (raw)
In-Reply-To: <23500000.1079289089@[10.10.2.4]>
On Sun, Mar 14, 2004 at 10:31:29AM -0800, Martin J. Bligh wrote:
>...
> New:
>...
> ~ ivtv Kevin Thayer / Steven Fuerst
> Driver for ivtv (includes Hauppauge PVR 250 / 350)
> Written by Kevin Thayer, ported to 2.6 by Steven Fuerst
> New version 0.1.9
>...
I got the following compile error:
<-- snip -->
...
CC drivers/media/video/ivtv-driver.o
In file included from drivers/media/video/ivtv.h:14,
from drivers/media/video/ivtv-driver.c:10:
include/linux/module.h:489: variable `__this_module' has initializer but
incomplete type
...
make[3]: *** [drivers/media/video/ivtv-driver.o] Error 1
<-- snip -->
The patch below fixes the braindead #define MODULE.
Additionally, it changes a PCI dependency from an error to a Kconfig
dependency.
cu
Adrian
--- linux-2.6.4-mjb1/drivers/media/video/ivtv.h.old 2004-03-14 23:11:04.000000000 +0100
+++ linux-2.6.4-mjb1/drivers/media/video/ivtv.h 2004-03-14 23:11:41.000000000 +0100
@@ -7,9 +7,6 @@
* License: GPL
* http://www.sourceforge.net/projects/ivtv/
*/
-#ifndef MODULE
- #define MODULE
-#endif
#include <linux/module.h>
#include <linux/init.h>
@@ -38,10 +35,6 @@
#include <linux/byteorder/swab.h>
#include <media/tuner.h>
-#ifndef CONFIG_PCI
-# error "This driver requires kernel PCI support."
-#endif
-
#define IVTV_ENCODER_OFFSET 0x00000000
#define IVTV_ENCODER_SIZE 0x01000000
--- linux-2.6.4-mjb1/drivers/media/video/Kconfig.old 2004-03-14 23:12:07.000000000 +0100
+++ linux-2.6.4-mjb1/drivers/media/video/Kconfig 2004-03-14 23:12:53.000000000 +0100
@@ -35,7 +35,7 @@
config VIDEO_IVTV_FB
tristate "IVTV Video For Linux Framebuffer"
- depends on VIDEO_IVTV && FB
+ depends on VIDEO_IVTV && FB && PCI
---help---
Support for Hauppauge WinTv PVR 350 boards TV Out via framebuffer.
next prev parent reply other threads:[~2004-03-14 22:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-14 18:31 2.6.4-mjb1 Martin J. Bligh
2004-03-14 21:05 ` 2.6.4-mjb1: No help text for VSYSCALL_GTOD Adrian Bunk
2004-03-14 22:20 ` Adrian Bunk [this message]
2004-03-14 22:23 ` 2.6.4-mjb1: ivtv-driver compile error Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040314222042.GK14833@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lse-tech@lists.sourceforge.net \
--cc=mbligh@aracnet.com \
--cc=nufan_wfk@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®