From: Tom Rini <trini@kernel.crashing.org>
To: Colin Leroy <colin@colino.net>
Cc: benh@kernel.crashing.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.6.4-bk3 ppc32 compile fix
Date: Mon, 15 Mar 2004 09:03:13 -0700 [thread overview]
Message-ID: <20040315160313.GB4342@smtp.west.cox.net> (raw)
In-Reply-To: <035701c40aa5$1549b490$3cc8a8c0@epro.dom>
On Mon, Mar 15, 2004 at 04:49:21PM +0100, Colin Leroy wrote:
> > > 2.6.4-bk3 (ie, 2.6.4 + bk3 patch at kernel.org) does not compile
> without this patch.
> >
> > How does it fail to compile?
>
> Same problem as here:
> http://marc.theaimsgroup.com/?l=linux-kernel&m=107935807420183&w=2
>
> include/asm/unistd.h:451: syntax error before "long"
>
> (maybe adding the #include <linux/linkage.h> to init/do_mounts_initrd.c is
> better than where I did put it).
The problem is that on PPC32 (and probably sparc64) 'asmlinkage' is a
useless keyword, and should just be removed from
include/asm-ppc/unistd.h.
--
Tom Rini
http://gate.crashing.org/~trini/
next prev parent reply other threads:[~2004-03-15 16:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-14 21:59 Colin Leroy
2004-03-15 15:51 ` Tom Rini
2004-03-15 15:49 ` Colin Leroy
2004-03-15 16:03 ` Tom Rini [this message]
2004-03-15 16:03 ` Colin Leroy
2004-03-15 16:12 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040315160313.GB4342@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=benh@kernel.crashing.org \
--cc=colin@colino.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®