mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: davej@redhat.com
To: linux-kernel@vger.kernel.org
Subject: [ALSA][2/6] Fix oops when initialisation fails.
Date: Mon, 15 Mar 2004 19:27:06 GMT	[thread overview]
Message-ID: <200403151927.i2FJR6KQ015688@delerium.codemonkey.org.uk> (raw)

Try modprobing a driver that the hardware doesn't exist for.
In a few situations, you'll hit an oops due to proc_id not
being filled out that early.

		Dave


--- linux-2.6.4/sound/core/init.c~	2004-03-15 17:45:20.000000000 +0000
+++ linux-2.6.4/sound/core/init.c	2004-03-15 17:45:40.000000000 +0000
@@ -281,7 +281,8 @@
 	}
 	if (card->private_free)
 		card->private_free(card);
-	snd_info_unregister(card->proc_id);
+	if (card->proc_id)
+		snd_info_unregister(card->proc_id);
 	if (snd_info_card_free(card) < 0) {
 		snd_printk(KERN_WARNING "unable to free card info\n");
 		/* Not fatal error */


                 reply	other threads:[~2004-03-15 19:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200403151927.i2FJR6KQ015688@delerium.codemonkey.org.uk \
    --to=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®