From: davej@redhat.com
To: linux-kernel@vger.kernel.org
Subject: [ALSA][6/6] Don't leave crap in /sys after module exit.
Date: Mon, 15 Mar 2004 19:27:07 GMT [thread overview]
Message-ID: <200403151927.i2FJR7mt015712@delerium.codemonkey.org.uk> (raw)
Here's a fun one. modprobe snd_dt019x.c when you don't have the hardware.
It fails to detect as expected, but doesn't stay around, so you don't
even need to rmmod it afterwards. Unfortunatly, it leaves around crap
in /sys/bus/pnp/drivers/dt019x which buggers up any subsequent usage of
the pnp code. Fix is easy : Keep the module around even when things fail.
Dave
--- linux-2.6.4/sound/isa/dt019x.c~ 2004-03-15 18:56:08.000000000 +0000
+++ linux-2.6.4/sound/isa/dt019x.c 2004-03-15 19:01:39.000000000 +0000
@@ -325,7 +325,7 @@
if (!cards)
snd_printk(KERN_ERR "no DT-019X / ALS-007 based soundcards found\n");
#endif
- return cards ? 0 : -ENODEV;
+ return cards < 0 ? cards : 0;
}
static void __exit alsa_card_dt019x_exit(void)
reply other threads:[~2004-03-15 19:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200403151927.i2FJR7mt015712@delerium.codemonkey.org.uk \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®