From: Anton Blanchard <anton@samba.org>
To: vojtech@suse.cz
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Recent input patch broke my keyboard
Date: Thu, 18 Mar 2004 15:27:44 +1100 [thread overview]
Message-ID: <20040318042744.GE28212@krispykreme> (raw)
Hi,
The patch below breaks my ppc64 box. None of the keys behave as expected :)
I also get a bunch of stuff in the dmesg:
atkbd.c: Use 'setkeycodes 66 <keycode>' to make it known.
atkbd.c: Unknown key pressed (translated set 2, code 0x66 on isa0060/serio0).
The boot messages show:
serio: i8042 AUX port at 0x60,0x64 irq 12
input: PS/2 Logitech Mouse on isa0060/serio1
serio: i8042 KBD port at 0x60,0x64 irq 1
input: AT Translated Set 2 keyboard on isa0060/serio0
If I back the patch out, things work again and I get:
serio: i8042 AUX port at 0x60,0x64 irq 12
input: PS/2 Logitech Mouse on isa0060/serio1
serio: i8042 KBD port at 0x60,0x64 irq 1
input: AT Raw Set 2 keyboard on isa0060/serio0
Sounds like assuming we are always in translate mode is bad for me.
Anton
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/03/03 15:14:01+01:00 vojtech@suse.cz
# input: i8042.c:
# Assume the chip always is in XLATE mode, even when it doesn't
# have the XLATE bit set - apparently IBM PS/2 model 70 behaves
# this way.
#
# drivers/input/serio/i8042.c
# 2004/03/03 15:13:56+01:00 vojtech@suse.cz +0 -8
# input: i8042.c:
# Assume the chip always is in XLATE mode, even when it doesn't
# have the XLATE bit set - apparently IBM PS/2 model 70 behaves
# this way.
#
diff -Nru a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
--- a/drivers/input/serio/i8042.c Thu Mar 18 15:06:59 2004
+++ b/drivers/input/serio/i8042.c Thu Mar 18 15:06:59 2004
@@ -722,14 +722,6 @@
}
/*
- * If the chip is configured into nontranslated mode by the BIOS, don't
- * bother enabling translating and be happy.
- */
-
- if (~i8042_ctr & I8042_CTR_XLATE)
- i8042_direct = 1;
-
-/*
* Set nontranslated mode for the kbd interface if requested by an option.
* After this the kbd interface becomes a simple serial in/out, like the aux
* interface is. We don't do this by default, since it can confuse notebook
reply other threads:[~2004-03-18 4:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040318042744.GE28212@krispykreme \
--to=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®