From: viro@parcelfarce.linux.theplanet.co.uk
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bind Mount Extensions 0.04 (linux-2.4.25)
Date: Thu, 18 Mar 2004 12:29:32 +0000 [thread overview]
Message-ID: <20040318122932.GK31500@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040315035559.GC30948@MAIL.13thfloor.at>
On Mon, Mar 15, 2004 at 04:55:59AM +0100, Herbert Poetzl wrote:
> if (count != 0) {
> - UPDATE_ATIME(file->f_dentry->d_inode);
> + UPDATE_ATIME(file->f_dentry->d_inode, file->f_vfsmnt);
For crying out loud... Make that touch_file(file) and be done with that.
There's a lot of places where we do just that (touch atime of opened file)
and passing pair of vfsmount and inode (not even vfsmount and dentry) is
just plain wrong.
next prev parent reply other threads:[~2004-03-18 12:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-15 3:55 Herbert Poetzl
2004-03-18 12:29 ` viro [this message]
2004-03-19 2:58 ` Herbert Poetzl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040318122932.GK31500@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®