From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Margit Schubert-While <margitsw@t-online.de>
Cc: linux-kernel@vger.kernel.org, ranty@debian.org
Subject: Re: 2.6.xx - linux/firmware.h - missing include
Date: Fri, 19 Mar 2004 15:30:08 +0000 [thread overview]
Message-ID: <20040319153008.D14431@flint.arm.linux.org.uk> (raw)
In-Reply-To: <5.1.0.14.2.20040319155257.00ac0af8@pop.t-online.de>; from margitsw@t-online.de on Fri, Mar 19, 2004 at 04:17:45PM +0100
On Fri, Mar 19, 2004 at 04:17:45PM +0100, Margit Schubert-While wrote:
> The prototype for request_firmware uses a struct device parameter.
> This is only defined if linux/device.h is included.
> Fix is simple : include linux/device.h in linux/firmware.h
That way leads to madness in the includes. firmware.h does not need
the definition of struct device, it only needs to know that struct
device exists.
You can do this via:
struct device;
before its use - this works much the same way as a function declaration
vs. function prototype.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-03-19 15:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-19 15:17 Margit Schubert-While
2004-03-19 15:30 ` Russell King [this message]
2004-03-19 18:36 ` Horst von Brand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040319153008.D14431@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=margitsw@t-online.de \
--cc=ranty@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome