From: Christoph Hellwig <hch@infradead.org>
To: Andrea Arcangeli <andrea@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.5-rc2-aa1
Date: Sun, 21 Mar 2004 16:24:01 +0000 [thread overview]
Message-ID: <20040321162401.A8778@infradead.org> (raw)
In-Reply-To: <20040321145547.GA3649@dualathlon.random>; from andrea@suse.de on Sun, Mar 21, 2004 at 03:55:47PM +0100
A bunch of rather cosmetic comments while looking over the patch:
- all the binfmt handler seems to copy exactly the same vma setup,
maybe we should add a helper for that?
- the struct anon_vma_s / anon_vma_t naming is awkward, why not just
struct anon_vma *insert reference to Documentation/CodingStyle here*
- the inclusion guards in objrmap.h are wrong
- why is PG_swapcache bit 21? You removed PG_direct so bit 16 is free now
- I don't really like the swapper space special case in ___add_to_page_cache,
IIRC there's only one caller of it for the swapper space and IMHO you're
better off opencoding it
- dito for __remove_from_page_cache
- is renaming rmap.c to objrmap.c really nessecary? It contains about
the same functions, and keeping the old, implementation-agnostic name
makes it easiert to follow the radical changes..
next prev parent reply other threads:[~2004-03-21 16:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-21 14:55 2.6.5-rc2-aa1 Andrea Arcangeli
2004-03-21 16:24 ` Christoph Hellwig [this message]
2004-03-21 23:43 ` 2.6.5-rc2-aa1 Andrea Arcangeli
2004-03-22 3:43 ` 2.6.5-rc2-aa1 Rik van Riel
2004-03-22 4:16 ` 2.6.5-rc2-aa1 Andrea Arcangeli
2004-03-22 14:07 ` 2.6.5-rc2-aa1 Rik van Riel
2004-03-22 14:14 ` 2.6.5-rc2-aa1 Andrea Arcangeli
2004-03-22 14:31 ` 2.6.5-rc2-aa1 Hugh Dickins
2004-03-22 14:50 ` 2.6.5-rc2-aa1 Andrea Arcangeli
2004-03-22 15:09 ` 2.6.5-rc2-aa1 Rik van Riel
2004-03-22 15:21 ` 2.6.5-rc2-aa1 Andrea Arcangeli
2004-03-22 15:43 ` 2.6.5-rc2-aa1 Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040321162401.A8778@infradead.org \
--to=hch@infradead.org \
--cc=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®